JDT Clean-up Use String.replace() instead of String.replaceAll() when #2277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Clean-up has issues eclipse-platform/eclipse.platform.ui#3544 |
Contributor
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
Contributor
Author
No this one is fine, thanks to verification from @merks |
Contributor
Author
|
Converrting to draft, as IMHO we should not apply such clean-ups shortly before a release. |
Contributor
Author
|
These changes also look fine to me. |
Contributor
Test Results 1 926 files 1 926 suites 1h 20m 55s ⏱️ For more details on these errors, see this check. Results for commit 177c7e2. ♻️ This comment has been updated with latest results. |
Member
|
Do you plan to finish this one? |
akurtakov
force-pushed
the
string-replace-cleanup
branch
from
53af68d to
91c4c95
Compare
vogella
force-pushed
the
string-replace-cleanup
branch
from
215a653 to
2f12095
Compare
possible In eclipse-platform/eclipse.platform.ui#3517 we discuss which automatic clean-ups we should add. This is the result of a manual run in eclipse-platform to see if this clean-up has issues. Also by running it manually before enabling the clean-ups we avoid creating PR per bundle.
vogella
force-pushed
the
string-replace-cleanup
branch
from
2f12095 to
177c7e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
possible
In eclipse-platform/eclipse.platform.ui#3517 we discuss which automatic clean-ups we should add. This is the result of a manual run in eclipse-platform to see if this clean-up has issues. Also by running it manually before enabling the clean-ups we avoid creating PR per bundle.