Enhance stack trace information for rule conflicts in BuildManager #2279
+47
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vogella
force-pushed
the
claude/enhance-stack-trace-info-01QAQgSR1KNnaVQwZBptdyDo
branch
from
e5b4927 to
b906eae
Compare
Contributor
vogella
force-pushed
the
claude/enhance-stack-trace-info-01QAQgSR1KNnaVQwZBptdyDo
branch
3 times, most recently
from
f754b17 to
02578f4
Compare
Fixes eclipse-platform#2278 When a builder attempts to begin or end a scheduling rule that doesn't match the outer scope rule, the error message now includes: - Builder name and label - Builder class name - Plugin ID - Project name - The conflicting rule This makes it much easier to identify which builder is causing the rule mismatch, especially in complex build scenarios with multiple builders. The enhancement catches IllegalArgumentException at the point where beginRule() and endRule() are called in BuildManager.basicBuild() and wraps it with detailed context before re-throwing.
vogella
force-pushed
the
claude/enhance-stack-trace-info-01QAQgSR1KNnaVQwZBptdyDo
branch
from
02578f4 to
d4e060e
Compare
Contributor
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
| // Acquire the rule required for running this builder | ||
| if (rule != null) { | ||
| Job.getJobManager().beginRule(rule, monitor); | ||
| try { |
Member
There was a problem hiding this comment.
Looks like two blocks differ only in string arguments. Can you please extract them to a static method handleRuleConflicts(boolean beginRule, InternalBuilder currentBuilder, IllegalArgumentException e)?
Could you please also add some example or just a test how the result error would look like?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2278
When a builder attempts to begin or end a scheduling rule that doesn't match the outer scope rule, the error message now includes:
This makes it much easier to identify which builder is causing the rule mismatch, especially in complex build scenarios with multiple builders.
The enhancement catches IllegalArgumentException at the point where beginRule() and endRule() are called in BuildManager.basicBuild() and wraps it with detailed context before re-throwing.