Skip to content

Conversation

@vogella
Copy link
Contributor

@vogella vogella commented Nov 15, 2025

tests

The ExpressionTestsPluginUnloading test was using com.ibm.icu bundle for testing plugin loading/unloading and classloader isolation. This change replaces it with org.eclipse.ant.core bundle to support removal of com.ibm.icu from the platform.

Changes:

  • Replace fake com.ibm.icu.text.DecimalFormat with org.eclipse.ant.core.AntRunner
  • Update test to use org.eclipse.ant.core bundle instead of com.ibm.icu
  • Adjust instanceof checks to match new bundle's class interfaces
  • org.eclipse.ant.core is a suitable replacement as it can be safely stopped/restarted without affecting test execution

@vogella vogella marked this pull request as draft November 15, 2025 11:23
@github-actions
Copy link
Contributor

github-actions bot commented Nov 15, 2025

Test Results

 1 953 files  ±0   1 953 suites  ±0   1h 26m 5s ⏱️ - 2m 11s
 4 744 tests ±0   4 720 ✅ ±0   24 💤 ±0  0 ❌ ±0 
14 232 runs  ±0  14 050 ✅ ±0  182 💤 ±0  0 ❌ ±0 

Results for commit ec3ef48. ± Comparison against base commit ad08006.

♻️ This comment has been updated with latest results.

@merks
Copy link
Contributor

merks commented Nov 15, 2025

Of course I have nothing again this change to a test.

There are some actual uses outside of test:

image

@akurtakov
Copy link
Member

@vogella Would you please take care of the ECA failure?

@eclipse-platform-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

runtime/tests/org.eclipse.core.expressions.tests/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From bf7bf5cc646094428f52e3c31b5e142401ea3351 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Fri, 12 Dec 2025 06:38:54 +0000
Subject: [PATCH] Version bump(s) for 4.39 stream


diff --git a/runtime/tests/org.eclipse.core.expressions.tests/META-INF/MANIFEST.MF b/runtime/tests/org.eclipse.core.expressions.tests/META-INF/MANIFEST.MF
index 1c9eae3130..7d71ae59d1 100644
--- a/runtime/tests/org.eclipse.core.expressions.tests/META-INF/MANIFEST.MF
+++ b/runtime/tests/org.eclipse.core.expressions.tests/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.core.expressions.tests; singleton:=true
-Bundle-Version: 3.7.600.qualifier
+Bundle-Version: 3.7.700.qualifier
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
 Export-Package: 
-- 
2.52.0

Further information are available in Common Build Issues - Missing version increments.

vogella and others added 2 commits December 12, 2025 09:36
tests

The ExpressionTestsPluginUnloading test was using com.ibm.icu bundle for
testing plugin loading/unloading and classloader isolation. This change
replaces it with org.eclipse.ant.core bundle to support removal of
com.ibm.icu from the platform.

Changes:
- Replace fake com.ibm.icu.text.DecimalFormat with
org.eclipse.ant.core.AntRunner
- Update test to use org.eclipse.ant.core bundle instead of com.ibm.icu
- Adjust instanceof checks to match new bundle's class interfaces
- org.eclipse.ant.core is a suitable replacement as it can be safely
  stopped/restarted without affecting test execution
@vogella vogella marked this pull request as ready for review December 12, 2025 08:37
@vogella vogella merged commit 29ff751 into eclipse-platform:master Dec 17, 2025
18 checks passed
@vogella vogella deleted the ibm.icu branch December 17, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants