Ensure the background payload starts #2323 #2324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
If background job with concurrent access payload does not have a chance to start, the test harness kills it prematurely. This change avoids a dependency on a job startup timing. Fixes eclipse-platform#2323
basilevs
force-pushed
the
premature_job_cancel_2323
branch
from
d81802d to
c8b849d
Compare
Contributor
Author
|
The new failure message may help to localize the problem. Please merge. |
Contributor
Author
|
Job cancellation was occasionally reported as a failure. I've fixed that in #2328 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If background job with concurrent access payload does not have a chance to start, the test harness kills it prematurely and produces a false positive.
This change avoids a dependency on a job startup timing.
As the test is failing even with these fixes, additional details are added to failure message.
Related to #2323.