build: add missing test dependencies to package workspaces to fix lint warnings #1461
+80
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18bharathkumar
requested review from
JKRhb,
danielpeintner,
egekorkan,
relu91 and
sebastiankb
as code owners
Member
danielpeintner
left a comment
danielpeintner
left a comment
There was a problem hiding this comment.
Thank you 👍
There is a CI consistency check that fails, see https://github.com/eclipse-thingweb/node-wot/actions/runs/20891164482/job/60048975528?pr=1461
eslint.config.mjs
Outdated
|
|
||
| // *************** Ensure that only used dependencies are imported *************** | ||
| "extraneous-dependencies/no-extraneous-dependencies": "off", // https://github.com/eclipse-thingweb/node-wot/issues/1430 | ||
| "extraneous-dependencies/no-extraneous-dependencies": "warn", // https://github.com/eclipse-thingweb/node-wot/issues/1430 |
Member
There was a problem hiding this comment.
Suggested change
| "extraneous-dependencies/no-extraneous-dependencies": "warn", // https://github.com/eclipse-thingweb/node-wot/issues/1430 | |
| "extraneous-dependencies/no-extraneous-dependencies": "warn", |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1461 +/- ##
==========================================
- Coverage 77.44% 77.42% -0.02%
==========================================
Files 83 83
Lines 15826 15826
Branches 1506 1503 -3
==========================================
- Hits 12256 12253 -3
- Misses 3545 3549 +4
+ Partials 25 24 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
relu91
reviewed
Jan 16, 2026
Comment on lines
+29
to
+39
| const packageDirs = [__dirname]; | ||
| const packagesRoot = path.join(__dirname, "packages"); | ||
| if (fs.existsSync(packagesRoot)) { | ||
| fs.readdirSync(packagesRoot).forEach((dir) => { | ||
| const pkgPath = path.join(packagesRoot, dir, "package.json"); | ||
| if (fs.existsSync(pkgPath)) { | ||
| packageDirs.push(path.join(packagesRoot, dir)); | ||
| } | ||
| }); | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Any reasons why we are collecting all the package directories?
relu91
reviewed
Jan 16, 2026
Comment on lines
-92
to
+110
| "extraneous-dependencies/no-extraneous-dependencies": "off", // https://github.com/eclipse-thingweb/node-wot/issues/1430 | ||
| // Default rule for root files | ||
| "extraneous-dependencies/no-extraneous-dependencies": [ | ||
| "warn", | ||
| { | ||
| packageDir: [__dirname], | ||
| }, | ||
| ], |
Member
There was a problem hiding this comment.
Why we don't simply apply it to all?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes
extraneous-dependencies/no-extraneous-dependencieswarnings while preserving the monorepo’s single-source-of-truth policy for shared dependencies.closes #1442
Test libraries remain declared only in the root
package.json. ESLint is updated to be monorepo-aware so workspace packages can correctly resolve hoisted dependencies.Changes
package.jsonfileseslint.config.mjsto validate dependencies against both root and workspace manifestsResult
npm run lintpassesnpm run check:versionspasses