-
Notifications
You must be signed in to change notification settings - Fork 27
releng: 11.2.0 release #369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
releng: 11.2.0 release #369
Conversation
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
WalkthroughParent POMs and module versions bumped from 11.0.0-SNAPSHOT → 11.2.0-SNAPSHOT across the workspace; target platform default and target/baseline definitions updated to e4.38/11.2.0; multiple target repository URLs and a few feature plugin declarations adjusted. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (87)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (56)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
🔇 Additional comments (32)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (3)
analysis/org.eclipse.tracecompass.analysis.lami.core.tests/pom.xml (1)
10-13: Split--><project ...>onto separate lines for consistency/tooling friendliness.--><project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd" xmlns="http://maven.apache.org/POM/4.0.0" +--> +<project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd" xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">pom.xml (1)
421-428: Update default target platform to match PR objective. The target artifact version was correctly bumped to 11.2.0-SNAPSHOT, but the default${target-platform}is still set totracecompass-e4.37(line 60 in pom.xml). Per the PR objective, this should be updated totracecompass-e4.38to align with the artifact version change. The target filetracecompass-e4.38.targetexists in the repository.releng/org.eclipse.tracecompass.target/pom.xml (1)
30-87: Add e4.26 through e4.38 to the attach-artifacts list; e4.38 is currently set as the default in TraceCompass.setup but is not being attached as an artifact. All target files from e4.26 to e4.38 exist on disk but are missing from the build-helper-maven-plugin configuration. When the build relies onorg.eclipse.tracecompass.target:tracecompass-e4.38:jar:tracecompass-e4.38, Maven artifact resolution will fail.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (89)
TraceCompass.setup(3 hunks)analysis/org.eclipse.tracecompass.analysis.counters.core.tests/pom.xml(1 hunks)analysis/org.eclipse.tracecompass.analysis.counters.ui.swtbot.tests/pom.xml(1 hunks)analysis/org.eclipse.tracecompass.analysis.graph.core.tests/pom.xml(1 hunks)analysis/org.eclipse.tracecompass.analysis.lami.core.tests/pom.xml(1 hunks)analysis/org.eclipse.tracecompass.analysis.lami.ui.swtbot.tests/pom.xml(1 hunks)analysis/org.eclipse.tracecompass.analysis.os.linux.core.tests/pom.xml(1 hunks)analysis/org.eclipse.tracecompass.analysis.os.linux.ui.swtbot.tests/pom.xml(1 hunks)analysis/org.eclipse.tracecompass.analysis.os.linux.ui.tests/pom.xml(1 hunks)analysis/org.eclipse.tracecompass.analysis.profiling.core.tests/pom.xml(1 hunks)analysis/org.eclipse.tracecompass.analysis.profiling.ui.swtbot.tests/pom.xml(1 hunks)analysis/org.eclipse.tracecompass.analysis.timing.core.tests/pom.xml(1 hunks)analysis/org.eclipse.tracecompass.analysis.timing.ui.swtbot.tests/pom.xml(1 hunks)analysis/pom.xml(1 hunks)btf/org.eclipse.tracecompass.btf.core.tests/pom.xml(1 hunks)btf/pom.xml(1 hunks)common/org.eclipse.tracecompass.common.core.tests/pom.xml(1 hunks)common/pom.xml(1 hunks)ctf/org.eclipse.tracecompass.ctf.core.tests/pom.xml(1 hunks)ctf/org.eclipse.tracecompass.ctf.parser.tests/pom.xml(1 hunks)ctf/org.eclipse.tracecompass.ctf.parser/pom.xml(1 hunks)ctf/org.eclipse.tracecompass.tmf.ctf.core.tests/pom.xml(1 hunks)ctf/org.eclipse.tracecompass.tmf.ctf.ui.swtbot.tests/pom.xml(1 hunks)ctf/pom.xml(1 hunks)doc/org.eclipse.tracecompass.analysis.profiling.doc.user/pom.xml(1 hunks)doc/org.eclipse.tracecompass.doc.dev/pom.xml(1 hunks)doc/org.eclipse.tracecompass.doc.user/pom.xml(1 hunks)doc/org.eclipse.tracecompass.gdbtrace.doc.user/pom.xml(1 hunks)doc/org.eclipse.tracecompass.rcp.doc.user/pom.xml(1 hunks)doc/org.eclipse.tracecompass.tmf.pcap.doc.user/pom.xml(1 hunks)doc/pom.xml(1 hunks)gdbtrace/org.eclipse.tracecompass.gdbtrace.core.tests/pom.xml(1 hunks)gdbtrace/org.eclipse.tracecompass.gdbtrace.ui.tests/pom.xml(1 hunks)gdbtrace/pom.xml(1 hunks)jsontrace/org.eclipse.tracecompass.jsontrace.core.tests/pom.xml(1 hunks)jsontrace/pom.xml(1 hunks)lttng/org.eclipse.tracecompass.lttng2.common.core.tests/pom.xml(1 hunks)lttng/org.eclipse.tracecompass.lttng2.control.core.tests/pom.xml(1 hunks)lttng/org.eclipse.tracecompass.lttng2.control.ui.swtbot.tests/pom.xml(1 hunks)lttng/org.eclipse.tracecompass.lttng2.control.ui.tests/pom.xml(1 hunks)lttng/org.eclipse.tracecompass.lttng2.kernel.core.tests/pom.xml(1 hunks)lttng/org.eclipse.tracecompass.lttng2.kernel.ui.swtbot.tests/pom.xml(1 hunks)lttng/org.eclipse.tracecompass.lttng2.ust.core.tests/pom.xml(1 hunks)lttng/org.eclipse.tracecompass.lttng2.ust.ui.swtbot.tests/pom.xml(1 hunks)lttng/org.eclipse.tracecompass.lttng2.ust.ui.tests/pom.xml(1 hunks)lttng/pom.xml(1 hunks)pcap/org.eclipse.tracecompass.pcap.core.tests/pom.xml(1 hunks)pcap/org.eclipse.tracecompass.tmf.pcap.core.tests/pom.xml(1 hunks)pcap/org.eclipse.tracecompass.tmf.pcap.ui.swtbot.tests/pom.xml(1 hunks)pcap/pom.xml(1 hunks)pom.xml(2 hunks)rcp/org.eclipse.tracecompass.rcp.branding.feature/pom.xml(1 hunks)rcp/org.eclipse.tracecompass.rcp.branding/pom.xml(1 hunks)rcp/org.eclipse.tracecompass.rcp.product/pom.xml(1 hunks)rcp/org.eclipse.tracecompass.rcp.rcptt.tests/pom.xml(1 hunks)rcp/org.eclipse.tracecompass.rcp.ui.tests/pom.xml(1 hunks)rcp/org.eclipse.tracecompass.rcp/feature.xml(1 hunks)rcp/org.eclipse.tracecompass.rcp/legacy-e4.37/feature.xml(2 hunks)rcp/org.eclipse.tracecompass.rcp/pom.xml(1 hunks)rcp/pom.xml(1 hunks)releng/org.eclipse.tracecompass.alltests/pom.xml(1 hunks)releng/org.eclipse.tracecompass.integration.core.tests/pom.xml(1 hunks)releng/org.eclipse.tracecompass.integration.swtbot.tests/pom.xml(1 hunks)releng/org.eclipse.tracecompass.releng-site/pom.xml(1 hunks)releng/org.eclipse.tracecompass.target/baseline/tracecompass-baseline-11.2.0.target(2 hunks)releng/org.eclipse.tracecompass.target/pom.xml(1 hunks)releng/org.eclipse.tracecompass.target/tracecompass-e4.38.target(6 hunks)releng/org.eclipse.tracecompass.target/tracecompass-eStaging.target(5 hunks)releng/pom.xml(1 hunks)statesystem/org.eclipse.tracecompass.datastore.core.tests/pom.xml(1 hunks)statesystem/org.eclipse.tracecompass.segmentstore.core.tests/pom.xml(1 hunks)statesystem/org.eclipse.tracecompass.statesystem.core.tests/pom.xml(1 hunks)statesystem/pom.xml(1 hunks)tmf/org.eclipse.tracecompass.tmf.analysis.xml.core.tests/pom.xml(1 hunks)tmf/org.eclipse.tracecompass.tmf.analysis.xml.ui.swtbot.tests/pom.xml(1 hunks)tmf/org.eclipse.tracecompass.tmf.analysis.xml.ui.tests/pom.xml(1 hunks)tmf/org.eclipse.tracecompass.tmf.chart.core.tests/pom.xml(1 hunks)tmf/org.eclipse.tracecompass.tmf.chart.ui.swtbot.tests/pom.xml(1 hunks)tmf/org.eclipse.tracecompass.tmf.chart.ui.tests/pom.xml(1 hunks)tmf/org.eclipse.tracecompass.tmf.cli.core.tests/pom.xml(1 hunks)tmf/org.eclipse.tracecompass.tmf.core.tests/pom.xml(1 hunks)tmf/org.eclipse.tracecompass.tmf.filter.parser/pom.xml(1 hunks)tmf/org.eclipse.tracecompass.tmf.remote.core.tests/pom.xml(1 hunks)tmf/org.eclipse.tracecompass.tmf.remote.ui.swtbot.tests/pom.xml(1 hunks)tmf/org.eclipse.tracecompass.tmf.remote.ui.tests/pom.xml(1 hunks)tmf/org.eclipse.tracecompass.tmf.ui.swtbot.tests/pom.xml(1 hunks)tmf/org.eclipse.tracecompass.tmf.ui.tests/pom.xml(1 hunks)tmf/org.eclipse.tracecompass.tmf.ui/pom.xml(1 hunks)tmf/pom.xml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: build / build
- GitHub Check: build / build
- GitHub Check: build / build
🔇 Additional comments (98)
doc/org.eclipse.tracecompass.tmf.pcap.doc.user/pom.xml (1)
16-20: Parent version bump looks correct; confirm explicit module<version>is intentional. Line 19 is fine. Please double-check whether this module should keep the explicit<version>11.2.0-SNAPSHOT</version>at Line 127 (vs inheriting from parent) to avoid future drift.rcp/pom.xml (1)
18-22: Straightforward parent version bump. Line 21 aligns this aggregator with the 11.2.0 baseline.btf/pom.xml (1)
18-22: Straightforward parent version bump. Line 21 looks consistent with the repo-wide 11.2.0 baseline.ctf/org.eclipse.tracecompass.tmf.ctf.ui.swtbot.tests/pom.xml (1)
16-21: Parent version bump OK; module versioning remains independent. Line 19 is good—just ensure keeping module<version>1.0.14-SNAPSHOT</version>(Line 27) is still the intended policy for this test plugin.pcap/pom.xml (1)
18-22: Straightforward parent version bump. Line 21 looks correct.doc/pom.xml (1)
18-22: Parent version bump OK; please ensure doc build still resolves pinned deps. Line 21 is fine—worth confirming the doc build still succeeds with the existing pinned WikiText/Guava versions under the new baseline.analysis/org.eclipse.tracecompass.analysis.os.linux.ui.swtbot.tests/pom.xml (1)
16-20: Parent version bump OK. Line 19 aligns the module with the 11.2.0 parent.common/org.eclipse.tracecompass.common.core.tests/pom.xml (1)
16-20: Parent version bump OK. Line 19 looks consistent with the release stream.ctf/org.eclipse.tracecompass.tmf.ctf.core.tests/pom.xml (1)
16-20: Parent version bump to 11.2.0-SNAPSHOT looks correct and consistent with the release.lttng/org.eclipse.tracecompass.lttng2.control.ui.tests/pom.xml (1)
16-20: Parent version bump to 11.2.0-SNAPSHOT is fine.ctf/pom.xml (1)
18-22: CTF parent POM aligned to 11.2.0-SNAPSHOT (expected for the release).releng/org.eclipse.tracecompass.integration.swtbot.tests/pom.xml (1)
16-20: Releng SWTBot integration tests parent bump to 11.2.0-SNAPSHOT is OK.analysis/org.eclipse.tracecompass.analysis.profiling.ui.swtbot.tests/pom.xml (1)
16-20: Analysis profiling SWTBot tests parent bump to 11.2.0-SNAPSHOT is OK.analysis/org.eclipse.tracecompass.analysis.graph.core.tests/pom.xml (1)
16-20: Analysis graph core tests parent bump to 11.2.0-SNAPSHOT is OK.tmf/org.eclipse.tracecompass.tmf.chart.core.tests/pom.xml (1)
16-20: TMF chart core tests parent bump to 11.2.0-SNAPSHOT is OK.releng/pom.xml (2)
18-22: Releng parent POM aligned to 11.2.0-SNAPSHOT (expected for 11.2.0 release train).
18-37: All parent versions are consistent at 11.2.0-SNAPSHOT across releng. No stale references to 11.0.0 or 11.1.0-SNAPSHOT remain in the repository. Baseline and target versions are properly aligned repo-wide.rcp/org.eclipse.tracecompass.rcp.product/pom.xml (1)
19-19: Version bump is consistent and correct.Parent version updated to 11.2.0-SNAPSHOT at line 19 and module version at line 309 are aligned. The change is straightforward and complete.
Also applies to: 309-309
statesystem/org.eclipse.tracecompass.datastore.core.tests/pom.xml (1)
19-19: Correct parent version bump for test module.Parent version updated to 11.2.0-SNAPSHOT. Test module version (1.0.11-SNAPSHOT) is preserved as expected.
lttng/org.eclipse.tracecompass.lttng2.ust.ui.tests/pom.xml (1)
19-19: Correct parent version update for LTTNG UI test module.Parent version bumped to 11.2.0-SNAPSHOT. Module version (1.0.4-SNAPSHOT) is appropriately maintained.
doc/org.eclipse.tracecompass.analysis.profiling.doc.user/pom.xml (1)
19-19: Documentation module version updated consistently.Parent version and module version both updated to 11.2.0-SNAPSHOT. Build configuration remains unchanged. Change is correct.
Also applies to: 125-125
doc/org.eclipse.tracecompass.rcp.doc.user/pom.xml (1)
19-19: RCP documentation module version updated correctly.Parent and module versions both aligned to 11.2.0-SNAPSHOT. Build configuration for documentation generation is preserved.
Also applies to: 127-127
pcap/org.eclipse.tracecompass.pcap.core.tests/pom.xml (1)
21-21: Correct parent version bump for PCAP test module.Parent version updated to 11.2.0-SNAPSHOT. Test module version (1.0.8-SNAPSHOT) and build profiles are preserved.
tmf/org.eclipse.tracecompass.tmf.ui.swtbot.tests/pom.xml (1)
19-19: Correct parent version update for TMF UI SWTBot test module.Parent version bumped to 11.2.0-SNAPSHOT. Module version (1.0.24-SNAPSHOT) is appropriately maintained.
analysis/org.eclipse.tracecompass.analysis.profiling.core.tests/pom.xml (1)
19-19: Correct parent version update for analysis profiling test module.Parent version bumped to 11.2.0-SNAPSHOT. Test module version (1.0.14-SNAPSHOT) is preserved as expected.
analysis/org.eclipse.tracecompass.analysis.counters.ui.swtbot.tests/pom.xml (1)
16-21: Version update approved.Parent version correctly bumped to 11.2.0-SNAPSHOT, maintaining proper inheritance chain.
tmf/pom.xml (1)
18-22: Version update approved.Parent version correctly bumped to 11.2.0-SNAPSHOT in this aggregator POM, which will cascade to all 15 child modules.
ctf/org.eclipse.tracecompass.ctf.parser.tests/pom.xml (1)
16-20: Version update approved.Parent version correctly bumped to 11.2.0-SNAPSHOT.
lttng/org.eclipse.tracecompass.lttng2.common.core.tests/pom.xml (1)
16-20: Version update approved.Parent version correctly bumped to 11.2.0-SNAPSHOT.
rcp/org.eclipse.tracecompass.rcp.rcptt.tests/pom.xml (1)
19-23: Version update approved.Parent version correctly bumped to 11.2.0-SNAPSHOT. External test trace dependencies remain at 1.6.0 as expected.
tmf/org.eclipse.tracecompass.tmf.core.tests/pom.xml (1)
16-21: Version update approved.Parent version correctly bumped to 11.2.0-SNAPSHOT.
ctf/org.eclipse.tracecompass.ctf.parser/pom.xml (1)
16-20: Version update approved.Parent version correctly bumped to 11.2.0-SNAPSHOT. Build configuration for ANTLR grammar processing remains unchanged.
releng/org.eclipse.tracecompass.integration.core.tests/pom.xml (1)
16-21: Parent version update is consistent across all modules.All 83 pom.xml files in the repository have been correctly updated to 11.2.0-SNAPSHOT, with no lingering references to previous versions. The releng-parent version bump in this file aligns with the broader codebase changes.
analysis/pom.xml (1)
18-22: Version bump aligns with 11.2.0-SNAPSHOT release.Parent version consistently updated. No functional changes.
statesystem/org.eclipse.tracecompass.segmentstore.core.tests/pom.xml (1)
16-20: Parent version updated consistently.Test module version retained independently. Change is correct.
tmf/org.eclipse.tracecompass.tmf.filter.parser/pom.xml (1)
19-23: Parent version updated; module version and build configuration unchanged.Filter parser module version correctly retained at 1.2.0-SNAPSHOT.
rcp/org.eclipse.tracecompass.rcp.ui.tests/pom.xml (1)
16-20: Parent version updated; test module version retained.Consistent with test module versioning pattern.
rcp/org.eclipse.tracecompass.rcp/pom.xml (2)
16-20: Parent version updated consistently.Change aligns with other modules.
140-140: Verify feature module version matches parent version intentionally.The feature module version is set to 11.2.0-SNAPSHOT, matching the parent. Confirm this versioning strategy is intentional for the feature release and doesn't conflict with constituent plugin versions.
btf/org.eclipse.tracecompass.btf.core.tests/pom.xml (1)
16-20: Parent version updated; test module version retained.Consistent with test module pattern across the repository.
tmf/org.eclipse.tracecompass.tmf.chart.ui.tests/pom.xml (1)
16-21: Parent version updated; test module version retained.Aligns with test module versioning across the project.
lttng/org.eclipse.tracecompass.lttng2.control.core.tests/pom.xml (1)
16-20: Parent version updated; test module version retained.Consistent with test module pattern in the repository.
tmf/org.eclipse.tracecompass.tmf.cli.core.tests/pom.xml (1)
16-20: Parent version bump looks consistent with release branch intent.doc/org.eclipse.tracecompass.gdbtrace.doc.user/pom.xml (1)
16-20: Version alignment (parent + module) looks correct for 11.2.0 development stream.Also applies to: 127-127
lttng/org.eclipse.tracecompass.lttng2.control.ui.swtbot.tests/pom.xml (1)
16-20: Parent version bump looks good.statesystem/pom.xml (1)
18-22: Parent version bump looks good.analysis/org.eclipse.tracecompass.analysis.timing.core.tests/pom.xml (1)
16-20: Parent version bump looks good.gdbtrace/org.eclipse.tracecompass.gdbtrace.core.tests/pom.xml (1)
16-20: Parent version bump looks good.analysis/org.eclipse.tracecompass.analysis.lami.core.tests/pom.xml (1)
15-20: Parent version bump looks good.tmf/org.eclipse.tracecompass.tmf.analysis.xml.ui.tests/pom.xml (1)
16-21: Parent version bump looks good.common/pom.xml (1)
21-21: Parent version update looks correct.The version bump from 11.0.0-SNAPSHOT to 11.2.0-SNAPSHOT is consistent with the PR's release objectives and aligns with the broader module version updates across the project.
lttng/org.eclipse.tracecompass.lttng2.ust.ui.swtbot.tests/pom.xml (1)
19-19: Parent version bump is correct.Aligns with the lttng-parent module hierarchy and the 11.2.0 release version bump.
tmf/org.eclipse.tracecompass.tmf.ui.tests/pom.xml (1)
19-19: Parent version bump is correct.Aligns with the tmf-parent module hierarchy and the 11.2.0 release version bump.
ctf/org.eclipse.tracecompass.ctf.core.tests/pom.xml (1)
21-21: Parent version bump is correct.Aligns with the ctf-parent module hierarchy and the 11.2.0 release version bump. Build configuration and test setup remain intact.
tmf/org.eclipse.tracecompass.tmf.analysis.xml.core.tests/pom.xml (1)
19-19: Parent version bump is correct.Aligns with the tmf-parent module hierarchy and the 11.2.0 release version bump.
lttng/org.eclipse.tracecompass.lttng2.kernel.ui.swtbot.tests/pom.xml (1)
19-19: Parent version bump is correct.Aligns with the lttng-parent module hierarchy and the 11.2.0 release version bump.
tmf/org.eclipse.tracecompass.tmf.chart.ui.swtbot.tests/pom.xml (1)
19-19: Parent version bump is correct.Aligns with the tmf-parent module hierarchy and the 11.2.0 release version bump.
tmf/org.eclipse.tracecompass.tmf.analysis.xml.ui.swtbot.tests/pom.xml (1)
19-19: Parent version bump is correct.Aligns with the tmf-parent module hierarchy and the 11.2.0 release version bump.
rcp/org.eclipse.tracecompass.rcp.branding.feature/pom.xml (1)
19-19: LGTM! Parent version updated correctly.The parent POM version has been updated to 11.2.0-SNAPSHOT, consistent with the release objectives.
gdbtrace/pom.xml (1)
21-21: LGTM! Parent version updated correctly.The parent version bump to 11.2.0-SNAPSHOT aligns with the release objectives.
releng/org.eclipse.tracecompass.target/tracecompass-e4.38.target (2)
1-1: LGTM! Sequence number incremented.The sequence number has been correctly incremented to reflect the target platform changes.
4-4: All target platform repository URLs are accessible.Verification confirms that all repositories have been successfully updated and are available:
- JustJ JRE 21.0.9 (HTTP 200)
- CDT 12.3.0 (HTTP 200)
- Orbit 4.38.0 (HTTP 200)
- Eclipse 4.38 R-4.38-202512010920 (HTTP 200)
- WebTools 3.40.0 (HTTP 200)
rcp/org.eclipse.tracecompass.rcp.branding/pom.xml (1)
24-24: LGTM! Parent version updated correctly.The parent POM version bump to 11.2.0-SNAPSHOT is consistent with the release.
analysis/org.eclipse.tracecompass.analysis.timing.ui.swtbot.tests/pom.xml (1)
19-19: LGTM! Parent version updated correctly.The parent version bump to 11.2.0-SNAPSHOT aligns with the release objectives.
doc/org.eclipse.tracecompass.doc.dev/pom.xml (1)
19-19: LGTM! Parent version updated correctly.The parent POM version has been updated to 11.2.0-SNAPSHOT, consistent with the release.
analysis/org.eclipse.tracecompass.analysis.counters.core.tests/pom.xml (1)
19-19: LGTM! Parent version updated correctly.The parent version bump to 11.2.0-SNAPSHOT is consistent with the release objectives.
analysis/org.eclipse.tracecompass.analysis.os.linux.ui.tests/pom.xml (1)
19-19: LGTM! Parent version updated correctly.The parent version bump to 11.2.0-SNAPSHOT aligns with the release objectives.
tmf/org.eclipse.tracecompass.tmf.remote.ui.tests/pom.xml (1)
16-20: Parent POM bump looks consistent with release branch intent.pcap/org.eclipse.tracecompass.tmf.pcap.ui.swtbot.tests/pom.xml (1)
16-20: Parent POM bump looks good.gdbtrace/org.eclipse.tracecompass.gdbtrace.ui.tests/pom.xml (1)
16-20: Parent POM bump looks good.tmf/org.eclipse.tracecompass.tmf.remote.core.tests/pom.xml (1)
16-21: Parent POM bump looks good.lttng/org.eclipse.tracecompass.lttng2.ust.core.tests/pom.xml (1)
16-20: Parent POM bump looks good.lttng/org.eclipse.tracecompass.lttng2.kernel.core.tests/pom.xml (1)
15-19: Parent POM bump looks good.tmf/org.eclipse.tracecompass.tmf.remote.ui.swtbot.tests/pom.xml (1)
16-20: Parent POM bump looks good.rcp/org.eclipse.tracecompass.rcp/legacy-e4.37/feature.xml (1)
192-195: Remove concern aboutorg.apache.commons.langversion conflict. Bothorg.apache.commons.langandorg.apache.commons.lang3are intentionally included in the target platform definition and consistently across all legacy features. The codebase uses onlycommons.lang3; the legacy Lang 2.x bundle is present to support compatibility with older target platforms and transitive dependencies. This is standard practice and not a source of version confusion.tmf/org.eclipse.tracecompass.tmf.ui/pom.xml (1)
19-19: LGTM!Parent version bump to 11.2.0-SNAPSHOT is correctly applied and aligns with the coordinated release.
analysis/org.eclipse.tracecompass.analysis.os.linux.core.tests/pom.xml (1)
19-19: LGTM!Parent version update to 11.2.0-SNAPSHOT correctly applied.
doc/org.eclipse.tracecompass.doc.user/pom.xml (1)
19-19: LGTM!Parent version and module version correctly updated to 11.2.0-SNAPSHOT for release.
Also applies to: 131-131
analysis/org.eclipse.tracecompass.analysis.lami.ui.swtbot.tests/pom.xml (1)
19-19: LGTM!Parent version correctly updated to 11.2.0-SNAPSHOT.
lttng/pom.xml (1)
21-21: LGTM!Parent POM version bump to 11.2.0-SNAPSHOT is correctly applied. This change cascades to all LTTng child modules.
releng/org.eclipse.tracecompass.alltests/pom.xml (1)
19-19: LGTM!Parent version correctly updated to 11.2.0-SNAPSHOT. Test configurations and profiles remain stable.
rcp/org.eclipse.tracecompass.rcp/feature.xml (2)
281-282: Verify plugin ID rename compatibility with e4.38 2025-12 target.The Mortbay Jasper plugin ID was renamed from
org.mortbay.jasper.apache-jsptoorg.mortbay.jasper.mortbay-apache-jsp. This change appears related to the updated e4.38 2025-12 target platform per PR objectives.Confirm that:
- The renamed plugin
org.mortbay.jasper.mortbay-apache-jspexists in the e4.38 2025-12 target platform repository.- The build successfully resolves this plugin when using the updated target.
- The feature build and p2 installation complete without errors related to this plugin.
Since you've confirmed thorough testing per the PR checklist, please ensure the target platform resolution was validated during that testing.
1-9: Release version is correctly set in feature manifest.The feature version is properly set to 11.2.0.qualifier, which is the correct format for a release build.
pcap/org.eclipse.tracecompass.tmf.pcap.core.tests/pom.xml (1)
19-19: LGTM!Parent version correctly updated to 11.2.0-SNAPSHOT.
statesystem/org.eclipse.tracecompass.statesystem.core.tests/pom.xml (1)
16-20: Parent version bump looks correct. This should keep the test plugin aligned with the 11.2.0 build.releng/org.eclipse.tracecompass.releng-site/pom.xml (1)
21-25: Parent version bump looks correct.pom.xml (1)
22-26: Root project version bump to 11.2.0-SNAPSHOT looks good.TraceCompass.setup (2)
76-142: Oomph default target updated to tracecompass-e4.38 + new 2025-12 choice: LGTM.
173-185: All baseline references totracecompass-baseline-11.2.0are consistent and properly resolved. The setup file has matchingid,name, andtargetNameattributes, and the corresponding target file exists atreleng/org.eclipse.tracecompass.target/baseline/tracecompass-baseline-11.2.0.target.jsontrace/org.eclipse.tracecompass.jsontrace.core.tests/pom.xml (1)
16-20: Parent version bump looks correct.jsontrace/pom.xml (1)
18-22: Parent version bump looks correct.releng/org.eclipse.tracecompass.target/pom.xml (1)
20-24: Parent version bump looks correct.releng/org.eclipse.tracecompass.target/tracecompass-eStaging.target (6)
1-1: LGTM! Standard sequenceNumber increment.The sequenceNumber bump from 263 to 264 correctly reflects the target platform update.
47-47: Orbit 4.38.0 release URL is accessible and properly configured.The Orbit repository URL returns HTTP 200 with valid p2 metadata (content.jar and artifacts.jar present). Version 4.38.0 correctly aligns with the Eclipse 2025-12 (4.38) release.
13-13: CDT 12.3.0 release repository URL is accessible and valid.The update to the CDT 12.3.0 final release repository is appropriate for this staging target configuration.
4-4: JustJ JRE 21.0.9 is the latest available version in the release repository and the URL is accessible. The update is appropriate for the Eclipse 2025-12 release.
74-74: Eclipse platform repository update to official 4.38 release.Repository transitioned from integration build (I-build) to the official Eclipse 4.38 release (R-build) with timestamp 202512010920 (December 1, 2025). The p2 repository is properly structured and accessible with all required metadata files present.
84-84: WebTools 3.40.0 release URL is accessible and valid.The transition from RC1 to the final release is appropriate. Both the base directory and the specific repository URL return HTTP 200 responses, confirming the release artifacts are available. The identical timestamp indicates the RC build was promoted to release status, which is standard practice when no issues are found during the release candidate phase.
releng/org.eclipse.tracecompass.target/baseline/tracecompass-baseline-11.2.0.target
Show resolved
Hide resolved
releng/org.eclipse.tracecompass.target/baseline/tracecompass-baseline-11.2.0.target
Outdated
Show resolved
Hide resolved
bhufmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. LGTM.
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Update missed pom.xml versions to 11.2.0 Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
What it does
releng: Update e4.38 and eStaging targets to 2025-12 release
releng: Add Trace Compass 11.2.0 baseline
releng: Update OOMPH setup file for 11.2.0
releng: Build with tracecompass-e4.38 target by default
How to test
Build with default target
Set tracecompass-11.2.0 baseline
Setup with OOMPH
Follow-ups
N/A
Review checklist
Summary by CodeRabbit
Chores
Refactor
✏️ Tip: You can customize this high-level summary in your review settings.