-
Notifications
You must be signed in to change notification settings - Fork 5
uftrace contribution #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
arfio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments, thanks for adding uftrace to the test traces!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a particular reason to add the binary to this patch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really, I can remove it.
uftrace/pom.xml
Outdated
| @@ -0,0 +1,81 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <!-- | |||
| Copyright (C) 2021 Ericsson and others | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2025?
| @@ -0,0 +1,74 @@ | |||
| /******************************************************************************* | |||
| * Copyright (c) 2024 Ericsson | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2025?
| */ | ||
| public enum UftraceTestTrace { | ||
| /** | ||
| * Example kernel trace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uftrace taken from foobar?
| import java.net.URL; | ||
|
|
||
| /** | ||
| * Here is the list of the available test traces for the Ftrace parser. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uftrace
| * | ||
| * The file is obtained by running uftrace on foobar | ||
| */ | ||
| TEST_FOOBAR("uftrace-foobar-demo/uftrace.dat", 16, 1), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uftrace.data
Allow testing of uftrace traces Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
e4dbcd2 to
e63b5bd
Compare
Allow testing of uftrace traces