Skip to content

Conversation

@MatthewKhouzam
Copy link
Contributor

Allow testing of uftrace traces

Copy link
Contributor

@arfio arfio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, thanks for adding uftrace to the test traces!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a particular reason to add the binary to this patch?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really, I can remove it.

uftrace/pom.xml Outdated
@@ -0,0 +1,81 @@
<?xml version="1.0" encoding="UTF-8"?>
<!--
Copyright (C) 2021 Ericsson and others
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2025?

@@ -0,0 +1,74 @@
/*******************************************************************************
* Copyright (c) 2024 Ericsson
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2025?

*/
public enum UftraceTestTrace {
/**
* Example kernel trace
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uftrace taken from foobar?

import java.net.URL;

/**
* Here is the list of the available test traces for the Ftrace parser.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uftrace

*
* The file is obtained by running uftrace on foobar
*/
TEST_FOOBAR("uftrace-foobar-demo/uftrace.dat", 16, 1),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uftrace.data

Allow testing of uftrace traces

Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants