Fix broken AppDelegate after injecting the sources#42
Open
karolszafranski wants to merge 1 commit intoeclipsesource:masterfrom
Open
Fix broken AppDelegate after injecting the sources#42karolszafranski wants to merge 1 commit intoeclipsesource:masterfrom
karolszafranski wants to merge 1 commit intoeclipsesource:masterfrom
Conversation
It's possible that methods implemented by this plugin are already implemented in AppDelegate.m file. Using the script with its current state leads to a compile-time error: "Duplicate implementation for a method: xxx" We have to check first if the method is implemented, and if it is then we inject the new code to the existing implementation. If it's not then we just put in the whole method. Like we did before.
karolszafranski
force-pushed
the
fix/custom-widget-script
branch
from
57650b2 to
e9f1909
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's possible that methods implemented by this plugin are already
implemented in AppDelegate.m file. Using the script with its current
state leads to a compile-time error:
"Duplicate implementation for a method: xxx"
We have to check first if the method is implemented, and if it is then
we inject the new code to the existing implementation. If it's not then
we just put in the whole method. Like we did before.