Skip to content

Comments

Tweak buf breaking rules to be clearer about preferred mitigation when fields/enums are deleted.#22

Merged
bleggett merged 2 commits intomainfrom
bleggett/remove-zone-state-exited
Feb 20, 2026
Merged

Tweak buf breaking rules to be clearer about preferred mitigation when fields/enums are deleted.#22
bleggett merged 2 commits intomainfrom
bleggett/remove-zone-state-exited

Conversation

@bleggett
Copy link
Collaborator

Also remove deprecated ZONE_STATE_EXITED

… fields/enums are deleted.

Also remove deprecated `ZONE_STATE_EXITED`
@github-actions
Copy link

github-actions bot commented Feb 20, 2026

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedFeb 20, 2026, 5:22 PM

@bleggett
Copy link
Collaborator Author

@Sweetsurbhi88 this should quiet some of the breaking lints in #21, as well as more clearly indicating proper mitigation (reserve deleted field ID/names) going forward.

I left the deleted message breaking lint in place with no mitigation hint, because I think message deletion probably always needs an explicit callout.

Copy link
Member

@azenla azenla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will note that ZONE_STATE_EXITED can still be used if the zone executable exits (though this should likely be removed and changed to key off of a panic or something)

@bleggett
Copy link
Collaborator Author

bleggett commented Feb 20, 2026

I will note that ZONE_STATE_EXITED can still be used if the zone executable exits (though this should likely be removed and changed to key off of a panic or something)

Yeah - that should unambiguously should map to the existing ZONE_STATE_FAILED in all cases, AFAICT

@bleggett bleggett merged commit 9250eaf into main Feb 20, 2026
2 checks passed
@bleggett bleggett deleted the bleggett/remove-zone-state-exited branch February 20, 2026 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants