Check for a dotfile config, fallback to before#26
Open
codeanpeace wants to merge 1 commit intoedgeimpulse:masterfrom
Open
Check for a dotfile config, fallback to before#26codeanpeace wants to merge 1 commit intoedgeimpulse:masterfrom
codeanpeace wants to merge 1 commit intoedgeimpulse:masterfrom
Conversation
Configuration files are normally dotfiles – filename preceded by a dot to hide from GUI – but Edge Impulse breaks this convention since its config file is located at `~/edge-impulse-config.json` rather than `~/.edge-impulse-config.json`. This updates the constructor function in `config.ts` to look for a hidden dotfile config before falling back to the non hidden config file. This should hopefully let those that care convert the Edge Impulse config file into a dotfile while not affecting others. note: this is very much a naive simple approach as I'm unfamiliar with the entirety of this CLI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configuration files are normally dotfiles – filename preceded by a dot to hide from GUI – but Edge Impulse breaks this convention since its config file is located at
~/edge-impulse-config.jsonrather than~/.edge-impulse-config.json. This updates the constructor function inconfig.tsto look for a hidden dotfile config before falling back to the non hidden config file. This should hopefully let those that care convert the Edge Impulse config file into a dotfile while not affecting others.note: this is very much a naive simple approach as I'm unfamiliar with the entirety of this CLI