Closed
Conversation
Author
|
I managed to "fix" most of the problems with
|
added 3 commits
January 19, 2026 18:47
If underlying string is good this conversion would not allocate.
Collaborator
|
Hi! Appreciate you taking the time to open this. We actually began working toward the v1 release (see PR #37, with some commits back from November), and we've published a pre-release version |
Author
It's working, thanks! I will close the PR then. 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
next@16.1again messed up withswc_coreversion in minor version bump:https://plugins.swc.rs/versions/range/768
I'm not a great Rust developer, so my code definitely can be bad.
Outdated information
Also, can someone help me with checking `pnpm build --build --test`? It turns out that on my machine with ArchLinux I cannot successfully complete this command even on clean master: ``` ty3uk@archlinux ~/D/W/effector-swc-plugin (feature/swc_core@50)> pnpm build --test==================
RUNNING: @latest
DONE
RUNNING: @swc0.96.9
Compiling swc_common v0.34.4
Compiling swc_error_reporters v20.0.0
error[E0432]: unresolved import
serde::__private--> /home/ty3uk/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/swc_common-0.34.4/src/private/mod.rs:3:9
|
3 | pub use serde::__private as serde;
| ^^^^^^^---------^^^^^^^^^
| | |
| | help: a similar name exists in the module:
private| no
__privatein the rootCompiling testing v19.0.0
For more information about this error, try
rustc --explain E0432.error: could not compile
swc_common(lib) due to 1 previous errorwarning: build failed, waiting for other jobs to finish...
error: could not compile
swc_common(lib) due to 1 previous errornode:internal/modules/run_main:107
triggerUncaughtException(
^
101
(Use
node --trace-uncaught ...to show where the exception was thrown)Node.js v24.11.1
ELIFECYCLE Command failed with exit code 1.