更新types, 更新travis.yml 最新的npminstall只支持node 8#24
Open
mengfei0053 wants to merge 3 commits intoeggjs:masterfrom
Open
更新types, 更新travis.yml 最新的npminstall只支持node 8#24mengfei0053 wants to merge 3 commits intoeggjs:masterfrom
mengfei0053 wants to merge 3 commits intoeggjs:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 9 9
=========================================
Hits 9 9 Continue to review full report at Codecov.
|
|
@atian25 大锅,你看这个pr可以合并了吗?最近用到 validator + ts 也遇到了类型提示不明显的情况,利用声明合并怎么都覆盖不了插件里面的类型声明,可能还是从源头上加上类型定义比较好解决一点。 |
|
我也遇到了覆盖不了插件中的*.d.ts声明的问题,希望早日Merge这个PR |
直接用parameter |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Checklist
npm testpassesAffected core subsystem(s)
Description of change