Skip to content

Conversation

@imays11
Copy link
Contributor

@imays11 imays11 commented Dec 5, 2025

Pull Request

Issue link(s):

Summary - What I changed

This rule is performing well in telemetry, low volume and expected alerts. No major changes to rule query.

  • reduced execution window
  • updated description and IG
  • added highlighted fields

How To Test

Plenty of test data in our stack to run this query against.
You can use this script for testing both API calls detected by the rule: trigger_impact_kms_cmk_disabled_or_scheduled_for_deletion.py

Screenshot of expected alerts for both API calls

Screenshot 2025-12-05 at 12 18 53 PM

…Deletion

This rule is performing well in telemetry, low volume and expected alerts. No major changes to rule query.
- reduced execution window
- updated description and IG
- added highlighted fields
@imays11 imays11 self-assigned this Dec 5, 2025
@imays11 imays11 added Integration: AWS AWS related rules Rule: Tuning tweaking or tuning an existing rule Team: TRADE Domain: Cloud labels Dec 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

Rule: Tuning - Guidelines

These guidelines serve as a reminder set of considerations when tuning an existing rule.

Documentation and Context

  • Detailed description of the suggested changes.
  • Provide example JSON data or screenshots.
  • Provide evidence of reducing benign events mistakenly identified as threats (False Positives).
  • Provide evidence of enhancing detection of true threats that were previously missed (False Negatives).
  • Provide evidence of optimizing resource consumption and execution time of detection rules (Performance).
  • Provide evidence of specific environment factors influencing customized rule tuning (Contextual Tuning).
  • Provide evidence of improvements made by modifying sensitivity by changing alert triggering thresholds (Threshold Adjustments).
  • Provide evidence of refining rules to better detect deviations from typical behavior (Behavioral Tuning).
  • Provide evidence of improvements of adjusting rules based on time-based patterns (Temporal Tuning).
  • Provide reasoning of adjusting priority or severity levels of alerts (Severity Tuning).
  • Provide evidence of improving quality integrity of our data used by detection rules (Data Quality).
  • Ensure the tuning includes necessary updates to the release documentation and versioning.

Rule Metadata Checks

  • updated_date matches the date of tuning PR merged.
  • min_stack_version should support the widest stack versions.
  • name and description should be descriptive and not include typos.
  • query should be inclusive, not overly exclusive. Review to ensure the original intent of the rule is maintained.

Testing and Validation

  • Validate that the tuned rule's performance is satisfactory and does not negatively impact the stack.
  • Ensure that the tuned rule has a low false positive rate.

Copy link
Contributor

@Mikaayenson Mikaayenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a Setup section still sitting in the guide that should be moved to the setup field.

@imays11
Copy link
Contributor Author

imays11 commented Dec 5, 2025

There was a Setup section still sitting in the guide that should be moved to the setup field.

@Mikaayenson The setup section was removed from the guide

@imays11 imays11 merged commit f2d8ab5 into main Dec 8, 2025
12 checks passed
@imays11 imays11 deleted the tune_aws_kms_key_deletion branch December 8, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants