-
Notifications
You must be signed in to change notification settings - Fork 612
[Rule Tuning] AWS KMS Customer Managed Key Disabled or Scheduled for Deletion #5417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…Deletion This rule is performing well in telemetry, low volume and expected alerts. No major changes to rule query. - reduced execution window - updated description and IG - added highlighted fields
Rule: Tuning - GuidelinesThese guidelines serve as a reminder set of considerations when tuning an existing rule. Documentation and Context
Rule Metadata Checks
Testing and Validation
|
Mikaayenson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a Setup section still sitting in the guide that should be moved to the setup field.
rules/integrations/aws/impact_kms_cmk_disabled_or_scheduled_for_deletion.toml
Show resolved
Hide resolved
@Mikaayenson The setup section was removed from the guide |
Pull Request
Issue link(s):
Summary - What I changed
This rule is performing well in telemetry, low volume and expected alerts. No major changes to rule query.
How To Test
Plenty of test data in our stack to run this query against.
You can use this script for testing both API calls detected by the rule: trigger_impact_kms_cmk_disabled_or_scheduled_for_deletion.py
Screenshot of expected alerts for both API calls