-
Notifications
You must be signed in to change notification settings - Fork 121
Ele 5120 fusion databricks bugfix #867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughRemoves a specific Postgres dbt 1.8.0 include from a GitHub Actions workflow and updates a Databricks macro to branch on dbt-fusion: using Changes
Sequence Diagram(s)sequenceDiagram
participant Caller
participant Macro as databricks__edr_make_temp_relation
participant Elem as elementary
participant BaseRel as base_relation
participant API as api.Relation
Caller->>Macro: invoke(tmp_identifier, base_relation)
Macro->>Elem: is_dbt_fusion()
alt Fusion path
Macro->>BaseRel: incorporate(path={identifier: tmp_identifier}, type='view')
Note right of BaseRel: Constructs temp relation via incorporate (fusion-specific)
BaseRel-->>Macro: temp_relation
else Non-fusion path
Macro->>API: create(identifier=tmp_identifier, type='view')
Note right of API: Constructs temp relation via API create (non-fusion)
API-->>Macro: temp_relation
end
Macro-->>Caller: return temp_relation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (15)
Comment |
|
👋 @haritamar |
| include: | ||
| # If we're not running on a specific dbt version, then always add postgres on 1.8.0 | ||
| - dbt-version: "${{ inputs.dbt-version || '1.8.0' }}" | ||
| warehouse-type: postgres |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests are no longer compatible with dbt<1.10.8 (though the package itself still is)
Summary by CodeRabbit