-
Notifications
You must be signed in to change notification settings - Fork 121
Ele 5121 dremio fix for replace table data #868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 @haritamar |
WalkthroughEnables artifact caching in two integration tests by setting Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant TestRunner
participant Macro as replace_table_data (spark/dremio)
participant DB as Target Database
TestRunner->>Macro: call replace_table_data(relation, rows)
Note over Macro: Engine-specific path (Spark or Dremio)
Macro->>DB: TRUNCATE relation
alt rows exist
loop per chunk
Macro->>DB: INSERT chunk (non-atomic)
end
else no rows
Note over Macro: skip inserts
end
Macro-->>TestRunner: return success
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (14)
Comment |
Summary by CodeRabbit
New Features
Performance
Tests