Skip to content

Conversation

@haritamar
Copy link
Collaborator

@haritamar haritamar commented Oct 9, 2025

Summary by CodeRabbit

  • Bug Fixes
    • Corrected dbt Fusion version detection to recognize only major version 2, preventing misclassification on other major versions and ensuring accurate feature gating and behavior across environments.

@linear
Copy link

linear bot commented Oct 9, 2025

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2025

👋 @haritamar
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in the elementary repository.

@haritamar haritamar changed the title is_dbt_fusion: check that it's exactly 2 is_dbt_fusion: check that the major is exactly 2 Oct 9, 2025
@coderabbitai
Copy link

coderabbitai bot commented Oct 9, 2025

Walkthrough

Updated the is_dbt_fusion macro to return true only when the dbt major version equals 2, instead of for all versions greater than 1.

Changes

Cohort / File(s) Summary
Macro logic update
macros/edr/system/system_utils/is_dbt_fusion.sql
Tightened condition: check major version == 2 instead of > 1 for is_dbt_fusion macro.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I twitch my ears at version two,
A tidy hop from “greater than” to “true.”
One macro wink, conditions lean,
Now fusion flips on only green.
I thump the ground—precise and neat,
Versioned veggies, crisp to eat! 🥕

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title succinctly summarizes the primary change by indicating that the is_dbt_fusion macro now checks for major version exactly equal to 2. It directly references the affected macro without unnecessary details or noise. This clarity ensures teammates can quickly understand the intent of the change from the title alone.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ele-5130-bugfix-for-dbt-cloud

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between bd63456 and 8204b9d.

📒 Files selected for processing (1)
  • macros/edr/system/system_utils/is_dbt_fusion.sql (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (13)
  • GitHub Check: test (latest_pre, postgres) / test
  • GitHub Check: test (latest_official, trino) / test
  • GitHub Check: test (fusion, snowflake) / test
  • GitHub Check: test (latest_official, snowflake) / test
  • GitHub Check: test (latest_official, athena) / test
  • GitHub Check: test (latest_official, postgres) / test
  • GitHub Check: test (latest_official, bigquery) / test
  • GitHub Check: test (fusion, redshift) / test
  • GitHub Check: test (fusion, databricks_catalog) / test
  • GitHub Check: test (fusion, bigquery) / test
  • GitHub Check: test (latest_official, redshift) / test
  • GitHub Check: test (latest_official, dremio) / test
  • GitHub Check: test (latest_official, databricks_catalog) / test

Comment @coderabbitai help to get the list of available commands and usage tips.

@haritamar haritamar merged commit ba690aa into master Oct 9, 2025
28 of 31 checks passed
@haritamar haritamar deleted the ele-5130-bugfix-for-dbt-cloud branch October 9, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants