Skip to content

Conversation

@GuyEshdat
Copy link
Contributor

@GuyEshdat GuyEshdat commented Dec 1, 2025

…it will match the code of the table

Summary by CodeRabbit

  • Bug Fixes
    • Expanded numeric capacity for key result tracking metrics to support larger values without overflow limitations.

✏️ Tip: You can customize this high-level summary in your review settings.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

👋 @GuyEshdat
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in the elementary repository.

@coderabbitai
Copy link

coderabbitai bot commented Dec 1, 2025

Walkthrough

The dbt_run_results model schema is updated to expand the numeric capacity of two columns: rows_affected and failures are changed from int to bigint data type to accommodate larger values.

Changes

Cohort / File(s) Summary
Schema type expansion
models/run_results.yml
Updated dbt_run_results model columns: rows_affected and failures data types changed from int to bigint

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 Hops of joy for bigger ints,
From cramped int to bigint hints,
More rows, more fails we now can hold,
Our numeric tales grow bold!

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: converting 'failures' and 'affected_rows' fields to bigint in the schema, which matches the raw summary showing these two columns changed from int to bigint.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bigint-types

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 15c3290 and 6c55867.

📒 Files selected for processing (1)
  • models/run_results.yml (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (14)
  • GitHub Check: test (latest_official, athena) / test
  • GitHub Check: test (fusion, databricks_catalog) / test
  • GitHub Check: test (latest_official, bigquery) / test
  • GitHub Check: test (latest_official, dremio) / test
  • GitHub Check: test (latest_official, databricks_catalog) / test
  • GitHub Check: test (fusion, snowflake) / test
  • GitHub Check: test (latest_official, snowflake) / test
  • GitHub Check: test (latest_official, postgres) / test
  • GitHub Check: test (fusion, redshift) / test
  • GitHub Check: test (latest_official, clickhouse) / test
  • GitHub Check: test (latest_official, trino) / test
  • GitHub Check: test (latest_official, redshift) / test
  • GitHub Check: test (latest_pre, postgres) / test
  • GitHub Check: test (fusion, bigquery) / test
🔇 Additional comments (1)
models/run_results.yml (1)

199-201: Schema changes match the underlying code implementation.

The rows_affected and failures columns are correctly defined as bigint in the dbt macro get_dbt_run_results_empty_table_query() (in macros/edr/dbt_artifacts/upload_run_results.sql), confirming these schema changes align with the actual table definition. Both columns benefit from the expanded numeric range, particularly for large datasets.


Comment @coderabbitai help to get the list of available commands and usage tips.

@GuyEshdat GuyEshdat merged commit 6551383 into master Dec 2, 2025
54 of 61 checks passed
@GuyEshdat GuyEshdat deleted the bigint-types branch December 2, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants