-
Notifications
You must be signed in to change notification settings - Fork 203
update dbt package reference #2080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
update dbt package reference #2080
Conversation
|
👋 @haritamar |
📝 WalkthroughWalkthroughThis change swaps the elementary dbt package source from the published version 0.21.0 to a git-based dependency pointing to a specific commit in the dbt-data-reliability repository, with corresponding lock file updates. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks✅ Passed checks (3 passed)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
elementary/monitor/dbt_project/packages.yml (1)
4-5: Consider adding a comment explaining the specific commit.The git-based dependency change aligns with the pattern for unreleased versions noted in the comments below. However, consider adding a brief inline comment explaining why this specific commit is needed (e.g., referencing the ELE-5191 fix mentioned in the PR title) to help future maintainers understand the temporary nature of this dependency.
🔎 Suggested enhancement with explanatory comment
+ # Using commit with fix for ELE-5191 (test_result_rows logic update) - git: https://github.com/elementary-data/dbt-data-reliability.git revision: 96f29dce3711f38c63f992bcaf8848b101d63194
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
elementary/monitor/dbt_project/package-lock.ymlelementary/monitor/dbt_project/packages.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: test / test
- GitHub Check: code-quality
🔇 Additional comments (2)
elementary/monitor/dbt_project/package-lock.yml (1)
4-6: Lock file correctly reflects the git-based dependency.The lock file change appropriately switches from a published package to a git-based dependency. The specified commit revision is valid and accessible in the repository, with the commit message "update dbt package reference" aligning with the intended change.
elementary/monitor/dbt_project/packages.yml (1)
4-5: Git commit is valid and accessible.The commit
96f29dce3711f38c63f992bcaf8848b101d63194exists and contains the expected test_result_rows changes:
- Commit message: "test_result_rows: add row_index and test_type"
- Modified files include
models/edr/run_results/test_result_rows.sqland related test handling logic
null
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.