Skip to content

Fix volume_threshold severity example and document warn/error behavior#2120

Open
joostboon wants to merge 1 commit intodocsfrom
fix-volume-threshold-severity-example
Open

Fix volume_threshold severity example and document warn/error behavior#2120
joostboon wants to merge 1 commit intodocsfrom
fix-volume-threshold-severity-example

Conversation

@joostboon
Copy link

@joostboon joostboon commented Feb 18, 2026

Summary

  • Remove misleading config.severity: error from the custom thresholds example (it overrides the built-in dual severity)
  • Add "How severity levels work" section explaining that the test already uses warn_if/error_if internally
  • Add <Warning> callout about not setting config.severity on this test

The test macro configures warn_if='>=1', error_if='>=2' internally, so dbt automatically warns at warn_threshold_percent and errors at error_threshold_percent. Setting config.severity: error overrides this and turns all warnings into errors.

Test plan

  • Verify page renders correctly with the new Warning callout

🤖 Generated with Claude Code

- Remove misleading config.severity: error from example
- Add "How severity levels work" section explaining the built-in
  dual severity (warn_if/error_if) behavior
- Add warning about not overriding with config.severity

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link

coderabbitai bot commented Feb 18, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-volume-threshold-severity-example

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments