Skip to content

Add databricks support #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mjrulesamrat wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add databricks support #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions edr_stager_dbt_project/macros/get_elementary_dbt_pkg_version.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,8 @@
{% set database = target.project %}
{{ return(database) }}
{% endmacro %}

{% macro databricks__target_database() %}
{% set database = target.schema %}
Copy link
Contributor

@elongl elongl Feb 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think host is more closely related to database.

Copy link
Contributor

@elongl elongl Feb 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've implemented it like this on the dbt package.

Copy link
Author

@mjrulesamrat mjrulesamrat Mar 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @elongl for the response.

Does that mean we have to open PR on elementary-data/dbt-data-reliability repository as well to complement changes in elementary-action repo?

{{ return(database) }}
{% endmacro %}