Add more date time functions#1134
Merged
billylanchantin merged 7 commits intoelixir-explorer:mainfrom Dec 18, 2025
Merged
Conversation
it's added in polars 0.51, but explorer is using 0.49
billylanchantin
approved these changes
Dec 18, 2025
Member
billylanchantin
left a comment
There was a problem hiding this comment.
Beautiful work, no notes! I always appreciate attention to detail ❤️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #1132
And I figured while I was at it I would add the rest of the missing datetime functions from Polars.
I added:
day_of_monthis_leap_yearquarter_of_year(Polars calls thisquarter)iso_yearnanosecondI skipped:
millisecondandmicrosecond, which are in most of the Polars datetime traits, but they're missing from https://docs.rs/polars/0.52.0/polars/series/struct.Series.htmldays_in_month, which wasn't added until Polars 0.51 (Explorer is on 0.49. Latest is 0.52)I also reordered the functions. They're now sorted by:
year,month,dayis_leap_year,quarter_of_year,day_of_yeariso_year,week_of_year,day_of_weekhour,minute,second,nanosecondAnd I also made a couple minor tweaks to tests and fixed a typo or two.