Skip to content

fix(xref): raise on --min-cycle-label <= 0 #15027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josevalim merged 1 commit into from
Dec 30, 2025
+10 −0
Merged

fix(xref): raise on --min-cycle-label <= 0 #15027

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/mix/lib/mix/tasks/xref.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1238,6 +1238,10 @@ defmodule Mix.Tasks.Xref do
Mix.raise("--min-cycle-label requires the --label option to be given")
end

if integer <= 0 do
Mix.raise("--min-cycle-label must be greater than 0")
end

integer
else
1
Expand Down
6 changes: 6 additions & 0 deletions lib/mix/test/mix/tasks/xref_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -579,6 +579,12 @@ defmodule Mix.Tasks.XrefTest do
""")
end

test "bad min_cycle_label" do
assert_raise Mix.Error, "--min-cycle-label must be greater than 0", fn ->
assert_graph(["--format", "cycles", "--label", "compile", "--min-cycle-label", "0"], "")
end
end

test "cycles with min_cycle_size greater than actual length" do
assert_graph(["--format", "cycles", "--min-cycle-size", "3"], """
No cycles found
Expand Down
Loading