Skip to content

Comments

feat: add instance_id metadata to logs#380

Merged
doorgan merged 1 commit intoelixir-lang:mainfrom
Draggu:telemetry
Feb 23, 2026
Merged

feat: add instance_id metadata to logs#380
doorgan merged 1 commit intoelixir-lang:mainfrom
Draggu:telemetry

Conversation

@Draggu
Copy link
Contributor

@Draggu Draggu commented Feb 12, 2026

This allows us to easily grab logs from a single expert run.

Also, make logs single-line where possible for future ease of parsing

@Draggu Draggu changed the title feat: Add instance_id metadata to logs feat: add instance_id metadata to logs Feb 12, 2026
@Draggu Draggu force-pushed the telemetry branch 2 times, most recently from 7599cc6 to bc92af2 Compare February 13, 2026 11:11
Copy link
Collaborator

@doorgan doorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, thank you! 💜

==> .expert/expert.log <==
08:57:39.037 instance_id=19C8A5C9B8B [info] Resolved entity: {:call, Rainet, :my_other_fun, 2}
08:57:39.047 instance_id=19C8A5C9B8B [debug] handled request client -> server textDocument/hover in 69ms

==> .expert/project.log <==

08:57:39.037 instance_id=19C8A5C9B8B [info] Resolved entity: {:call, Rainet, :my_other_fun, 2}

==> .expert/expert.log <==
08:57:40.454 instance_id=19C8A5BB43F [debug] handled request client -> server textDocument/codeLens in 11ms
08:57:41.666 instance_id=19C8A5BB43F [info] Resolved entity: {:call, Rainet, :my_other_fun, 2}
08:57:41.683 instance_id=19C8A5BB43F [debug] handled request client -> server textDocument/hover in 99ms

I recall there was a line that turned logs into a single line for "future parsing" but I don't see it anymore. I think removing that was a good call, let's re-add it if necessary in the PR that implements that parsing.

Let's fix the conflicts and I think this is good to go

@mhanberg
Copy link
Member

I recall there was a line that turned logs into a single line for "future parsing" but I don't see it anymore

I had said I think it's a readability issue. I believe he removed it after.

This allows us to easily grab logs from single expert run
@doorgan doorgan merged commit 5c209be into elixir-lang:main Feb 23, 2026
37 checks passed
mhanberg pushed a commit that referenced this pull request Feb 24, 2026
🤖 I have created a release *beep* *boop*
---


##
[0.1.0-rc.2](v0.1.0-rc.1...v0.1.0-rc.2)
(2026-02-24)


### Features

* add `instance_id` metadata to logs
([#380](#380))
([5c209be](5c209be))


### Bug Fixes

* ensure `MIX_BUILD_PATH` is set for child processes
([#436](#436))
([3178302](3178302))
* **expert:** check start_child return in initialized handler
([#371](#371))
([de979ce](de979ce))
* forward logs through window log handler
([#418](#418))
([c608dc8](c608dc8)),
closes [#382](#382)
* support multiple elixir versions on multiroot projects
([#413](#413))
([dee595d](dee595d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants