fix: forward logs through window log handler#418
Open
mkaput wants to merge 1 commit intoelixir-lang:mainfrom
Open
fix: forward logs through window log handler#418mkaput wants to merge 1 commit intoelixir-lang:mainfrom
mkaput wants to merge 1 commit intoelixir-lang:mainfrom
Conversation
Add a centralized logger-to-LSP bridge for window/logMessage instead of ad hoc GenLSP.log/info/error calls. This routes operational logs through one path and keeps window/showMessage for explicit errors. Implement Expert.Logging.WindowLogHandler with runtime attachment, recursion guards, OTP/SASL/report filtering, and OTP 25/26+ compatibility via Expert.Logging.LoggerHandler. Wire attachment during app boot and test bootstrap, and route engine init events to lsp.pid so non-default test servers receive them. Add client-based gating for Emacs/Eglot in configuration (issue elixir-lang#382 workaround), plus tests covering config behavior, handler idempotency/replacement, and Emacs suppression semantics. fix elixir-lang#382
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a centralized logger-to-LSP bridge for window/logMessage instead of ad hoc GenLSP.log/info/error calls. This routes operational logs through one path and keeps window/showMessage for explicit errors.
Implement Expert.Logging.WindowLogHandler with runtime attachment, recursion guards, OTP/SASL/report filtering, and OTP 25/26+ compatibility via Expert.Logging.LoggerHandler. Wire attachment during app boot and test bootstrap, and route engine init events to lsp.pid so non-default test servers receive them.
Add client-based gating for Emacs/Eglot in configuration (issue #382 workaround), plus tests covering config behavior, handler idempotency/replacement, and Emacs suppression semantics.
fix #382
CleanShot.2026-02-20.at.14.20.26.mp4