Skip to content
This repository was archived by the owner on Aug 5, 2025. It is now read-only.

Conversation

@amokio
Copy link

@amokio amokio commented Sep 29, 2023

I believe only one subscription per Client is supported before, and only work for single client.

example:

client1 -> subscribe -> test {id: 1, method: "subscription",…}
client1 -> subscribe -> test2 {id: 2, method: "subscription",…}
client2 -> subscribe -> test {id: 1, method: "subscription",…}
client2 -> subscribe -> test {id: 2, method: "subscription",…}

Client2 will override Client1 Unsubscribable object.
observers { 1: Unsubscribable, 2: Unsubscribable }, Here may have memory leak and the observer still listener on event emitter.

proposed data structure :

{
  "[socket.id]": { "[id]": Unsubscribable }
}

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant