DCE away base64ReverseLookup #26126
Open
DCE away base64ReverseLookup #26126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nabled, the base64Decode function was being emitted, and Closure was unable to DCE away the dependent base64ReverseLookup variable. So optimize this away manually to save code size.
sbc100
reviewed
Jan 16, 2026
| // Decodes a _known valid_ base64 string (without validation) and returns it as a new Uint8Array. | ||
| // Benchmarked to be around 5x faster compared to a simple | ||
| // "Uint8Array.from(atob(b64), c => c.charCodeAt(0))" (TODO: perhaps use this form in -Oz builds?) | ||
| #if !JS_BASE64_API |
Collaborator
There was a problem hiding this comment.
How does does JS_BASE64_API relate to SINGLE_FILE_BINARY_ENCODE? The PR description only talks about that later.
Collaborator
Author
There was a problem hiding this comment.
Ah sorry, that was not so clear with GitHub diff.
By static reading the base64Decode() function starts
$base64Decode: (b64) => {
#if JS_BASE64_API
return Uint8Array.fromBase64(b64);
#else
i.e. the base64ReverseLookup object is never accessed if JS_BASE64_API is defined. So I updated the ifdef here to be consistent with that scenario as well.
sbc100
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building -sSINGLE_FILE builds with -sSINGLE_FILE_BINARY_ENCODE enabled, the base64Decode function was being emitted, and Closure was unable to DCE away the dependent base64ReverseLookup variable. So optimize this away manually to save code size.