Fix logReadFiles tracking message
#26189
Merged
+54
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
fix_logReadFiles
branch
from
0af5542 to
f3f101d
Compare
sbc100
force-pushed
the
fix_logReadFiles
branch
from
f3f101d to
ec3771b
Compare
Back in emscripten-core#7418 this message was updated, I believe in error. This logging is not related to `FS.trackingDelegate` and it not logging any kind of error. As a followup we should look at removing `logReadFiles` completely, or at least removing from `INCOMING_MODULE_JS_API` by default. Also, add a test for this feature.
sbc100
force-pushed
the
fix_logReadFiles
branch
from
ec3771b to
6238f58
Compare
Collaborator
Author
|
All of the code size changes here are more than made up for once we remove this from |
sbc100
changed the title
logReadFiles tacking messagelogReadFiles tracking message
kripken
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back in #7418 this message was updated, I believe in error. This logging is not related to
FS.trackingDelegateand it not logging any kind of error.As a followup we should look at removing
logReadFilescompletely, or at least removing fromINCOMING_MODULE_JS_APIby default.The
FS_DEBUGwas (again incorrectly) added in #15005Also, add a test for this feature.