Move NO_EDIT template assets to assets/ #1821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we included various template PNGs (and in some cases Aseprite source files) in the NO_EDIT template quest. Unlike the SpriteFrames resources and dialogue files (where it's easiest to edit them in-place rather than duplicate them), we've not seen people inadvertently editing the template PNG files in-place. It's more common for those who are drawing their own art to copy a new file from whatever tool they are using (e.g. Piskel) into their StoryQuest. Many of the StoryQuests I have reviewed have contained unmodified copies of the various PNGs, either used or unused. Move these assets to assets so we don't end up with so many unused duplicates. Update all references. #1359
Member
Author
|
@jgbourque Please take a look! This is what we discussed on #1359 but I want to draw your attention to it in case any learning materials will need to be updated. |
|
Play this branch at https://play.threadbare.game/branches/endlessm/wjt/move-no-edit-template-assets-to-assets. (This launches the game from the start, not directly at the change(s) in this pull request.) |
Member
Author
|
Landing this without further review on the basis of #1359 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we included various template PNGs (and in some cases Aseprite source
files) in the NO_EDIT template quest.
Unlike the SpriteFrames resources and dialogue files (where it's easiest to edit
them in-place rather than duplicate them), we've not seen people inadvertently
editing the template PNG files in-place. It's more common for those who are
drawing their own art to copy a new file from whatever tool they are using (e.g.
Piskel) into their StoryQuest. Many of the StoryQuests I have reviewed have
contained unmodified copies of the various PNGs, either used or unused.
Move these assets to assets so we don't end up with so many unused duplicates.
Update all references.
Resolves #1359