Sequence puzzle object: Remove 0.7× sprite scale #1835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the music puzzle and stealth+sequence combo used the sequence_puzzle_object scene, overriding its sprite frames for each instance. Instead, duplicate the scene for the musical rock, and replace all the relevant instances. This means the collision shapes can be specific to this rock. As part of this, I removed the 0.7× zoom on the AnimatedSprite2D and adjusted the interact area & collision accordingly. Helps #679
The object sprite and SpriteFrames are identical to the NO_EDIT template. Remove the copy in this quest.
Previously there were three sequence puzzle scenes in this quest: - 3_sequence_puzzle/Adornos_y_animaciones/prueba.tscn: unused - 3_sequence_puzzle/wizzy_quest_sequence_puzzle.tscn: copy of NO_EDIT template with player & object sprites swapped - 3_sequence_puzzle/wizzy_quest_puzzle_2.tscn: Inherits from wizzy_quest_sequence_puzzle.tscn It is the third one, wizzy_quest_puzzle_2.tscn, which is referenced from 1_stealth/wizzy_quest_stealth.tscn. Remove the unused prueba.tscn. Make wizzy_quest_puzzle_2.tscn a standalone scene. Delete wizzy_quest_sequence_puzzle.tscn.
Previously the AnimatedSprite2D node was scaled by (0.7, 0.7). This is quite strange for what is essentially a template: it means that learners draw a sprite based on our 96×96 × 3 frames template, then drop it into the scene and discover that it is drawn at 67.2 × 67.2 px (not even an integer scale). Reset the scale to 1×. Adjust the collision shapes for the SolidBody and the InteractArea accordingly. Tweak two of the scenes that use it to deal with the increased size. (I checked the others and they all still look & work OK.) Fixes #679
|
Play this branch at https://play.threadbare.game/branches/endlessm/wjt/sequence-puzzle-object-remove-0-7-sprite-scale. (This launches the game from the start, not directly at the change(s) in this pull request.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the AnimatedSprite2D node was scaled by (0.7, 0.7). This is
quite strange for what is essentially a template: it means that learners
draw a sprite based on our 96×96 × 3 frames template, then drop it into
the scene and discover that it is drawn at 67.2 × 67.2 px (not even an
integer scale).
Reset the scale to 1×. Adjust the collision shapes for the SolidBody and
the InteractArea accordingly. Tweak two of the scenes that use it to
deal with the increased size. (I checked the others and they all still
look & work OK.)
Fixes #679