storyquest_bootstrap: Free scenes after duplicating them #1841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to duplicate a .tscn file, we load it as a PackedScene, instantiate it, modify that instance, pack it, and save the new PackedScene. Previously the instance was leaked. Free it. This is not needed for any other types handled by this tool because Resources are RefCounted; PackedScene is a Resource, but the instanced scene is a Node which is not a RefCounted.
|
Play this branch at https://play.threadbare.game/branches/endlessm/wjt/storyquest-bootstrap-free-scenes-after-duplicating-them. (This launches the game from the start, not directly at the change(s) in this pull request.) |
wjt
deleted the
wjt/storyquest-bootstrap-free-scenes-after-duplicating-them
branch
manuq
reviewed
Jan 24, 2026
| result = ResourceSaver.save(copied) | ||
| assert(result == OK, error_string(result)) | ||
|
|
||
| scene.free() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to duplicate a .tscn file, we load it as a PackedScene,
instantiate it, modify that instance, pack it, and save the new
PackedScene. Previously the instance was leaked. Free it.
This is not needed for any other types handled by this tool because
Resources are RefCounted; PackedScene is a Resource, but the instanced
scene is a Node which is not a RefCounted.