Template Elder: Fix quest directory #1859
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the template elder's quest directory was overridden in
Fray's End. The overridden value was
res://scenes/quests/template_quests/NO_EDIT/. This is not correct: the
directory is res://scenes/quests/template_quests/, and the one quest
within it is NO_EDIT.
But funnily enough this happened to work almost correctly! The Storybook
initialisation logic did almost nothing (no files matched
"${quest_directory}/*/quest.tres" so the rest was skipped); but the
default quest for the StorybookPage scene is the NO_EDIT quest, so this
was shown without a table of contents. This is why we did not notice the
problem.
Define the quest directory in the template_elder scene, not in
frays_end. Set the directory correctly.
|
Play this branch at https://play.threadbare.game/branches/endlessm/wjt/template-elder-fix-quest-directory. (This launches the game from the start, not directly at the change(s) in this pull request.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the template elder's quest directory was overridden in
Fray's End. The overridden value was
res://scenes/quests/template_quests/NO_EDIT/. This is not correct: the
directory is res://scenes/quests/template_quests/, and the one quest
within it is NO_EDIT.
But funnily enough this happened to work almost correctly! The Storybook
initialisation logic did almost nothing (no files matched
"${quest_directory}/*/quest.tres" so the rest was skipped); but the
default quest for the StorybookPage scene is the NO_EDIT quest, so this
was shown without a table of contents. This is why we did not notice the
problem.
Define the quest directory in the template_elder scene, not in
frays_end. Set the directory correctly.