Refactor geometry module: improve type handling, validation, and docu…#146
Conversation
|
nice work, there is a good human touch which i personally feel in this code changes , i hope this is not entirely AI generated , but code looks way to perfect 😃 👍, but i some how feel it a good hand written code i think i started this module for making induction motor circle diagram, power circle diagram which i encountered during my electrical engineering course This pr looks god but i need some more time to review , as i coded it 3 years back @engineerjoe440 , if test cases pass i am fine with this to be merged |
|
This looks like some good work! Thank you for the "kickstart" to get some of this work moving. :) I see that we've got some failing tests, but those appear to be related to some unrelated issues. Can you please list any issues which this pull request addresses?
|
|
@engineerjoe440 this improve the code quality and correcting the returns types of some functions and adding details docs to it |
3 participants
…mentation