Update constants, conversions, thermal, and latex modules#148
Open
marcostfermin wants to merge 1 commit intoengineerjoe440:developfrom
Open
Update constants, conversions, thermal, and latex modules#148marcostfermin wants to merge 1 commit intoengineerjoe440:developfrom
marcostfermin wants to merge 1 commit intoengineerjoe440:developfrom
Conversation
engineerjoe440
requested changes
Feb 1, 2026
| """ | ||
| return kWh * KWH_PER_BTU | ||
| # constants.KWH_PER_BTU is kWh per BTU, so invert to get BTU per kWh | ||
| return kWh / KWH_PER_BTU |
Owner
There was a problem hiding this comment.
This is a good catch! Can we also add a test to make sure that I don't somehow screw this up in the future? We should be able to make a small test just to verify the function.
| in either polar or rectangular form. May generate both dollar | ||
| signs. | ||
|
|
||
| Parameters |
Owner
There was a problem hiding this comment.
Why are we removing the documentation for parameters? I'm generally a fan of more documentation then less.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.