Conversation
Signed-off-by: macdonst <simon.macdonald@gmail.com>
ryanbethel
reviewed
Apr 4, 2024
Contributor
ryanbethel
left a comment
ryanbethel
left a comment
There was a problem hiding this comment.
I like that ok. I agree we don't want to parse and update an element.mjs if they already have one. But what if in addition to printing instructions we write an elements.mjs.example or add a comment to the top of elements.mjs. My concern is if I somehow miss the terminal output or close it I am lost.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WDYT?
The issue with this approach is what happens when you import multiple things into
app/elements.mjs. For now I just print some instructions. Otherwise I think reading theapp/elements.mjscould get pretty gnarly.