Refactor where starter project version is determined#15
Open
Refactor where starter project version is determined#15
Conversation
Signed-off-by: macdonst <simon.macdonald@gmail.com>
Contributor
|
Thanks for looking into this! I didn't get a chance to comment on this but I was hoping that this version magic would use a semver parser and not be a hardcoded by hand number. The intent was to just keep from upgrading users to a breaking change. Was this already resolved upstream? |
Contributor
Author
|
@kristoferjoseph I can change this to a semver. I stayed away from that initially in order to not add another dependency to this project. Let's talk about the way it works in Enhance Sync. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to be able to re-use this code in the Begin CLI I needed to refactor where we determine the starter project version. Taking it out of create project allows me to build a CJS version of that file that can be used in the Begin CLI.
Signed-off-by: macdonst simon.macdonald@gmail.com