feat: Add 7702 Semi-Modular Account Support#213
Merged
Conversation
Summary by OctaneNew Contracts
Updated Contracts
🔗 Commit Hash: f9215cd |
Overview
Detailed findings
|
howydev
approved these changes
Jan 31, 2025
Collaborator
howydev
left a comment
There was a problem hiding this comment.
LGTM
1 small security callout is that the upgradeToAndCall path still exists to perform an arbitrary call on the account, but this should be protected in the default cases of selector validation since that's an allowlist model
jaypaik
pushed a commit
that referenced
this pull request
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
With EIP-7702 around the corner, developers would benefit from having a simple example of a Semi-Modular Account with a fallback signer that defaults to the address of the account itself.
Solution
Implement a variant of the Semi-Modular Account which includes the address of the account itself as the fallback signer rather than reading from bytecode as is done in the standard Semi-Modular Account.
This PR also affects the base Semi-Modular Account contract by making the account ID and unchecked fallback signer getter functions virtual as they must be overriden in the 7702 variant.