-
Notifications
You must be signed in to change notification settings - Fork 0
Sync upstream SponsorBlock 6.1.0 and DeArrow 2.1.11 #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…..13ddd1f) - Update to SponsorBlock 6.1.0 with 98 new commits including: - Skip profiles feature - YouTube layout fixes for new design - Advanced skip options improvements - Pride theme support - Better chapter handling - Update to DeArrow 2.1.11 with 35 new commits including: - Title formatting improvements - Thumbnail renderer updates - YouTube layout fixes - Better error handling - Preserve EditTogether branding throughout: - Updated manifest.json to version 6.1.0 - Maintained EditTogether icons and branding in HTML files - Updated help page and options page with EditTogether identity - Kept EditTogether-specific configuration Co-Authored-By: Erkin Alp Güney <erkinalp9035@gmail.com>
Update maze-utils to match SponsorBlock 6.1.0 requirements. This includes fixes for background script and new exports needed by the updated code. Co-Authored-By: Erkin Alp Güney <erkinalp9035@gmail.com>
- Add svgIcons directory with icon components from DeArrow - Add license directory with LicenseComponent from DeArrow - Add ToggleOptionComponent and FormattedTextComponent from DeArrow - Add logWarn function to logger for compatibility Co-Authored-By: Erkin Alp Güney <erkinalp9035@gmail.com>
Contributor
Author
Original prompt from Erkin |
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Add formatCasualTitles property to SBConfig interface and sync defaults to match DeArrow upstream requirements. Co-Authored-By: Erkin Alp Güney <erkinalp9035@gmail.com>
- Add optional headers parameter to asyncRequestToServer and sendRequestToServer - Add optional titleFormatting prop to YourWorkComponent to match DeArrow upstream - These changes resolve TypeScript compilation errors from upstream sync Co-Authored-By: Erkin Alp Güney <erkinalp9035@gmail.com>
- Make actualValue optional in ShowCustomBrandingInfo union type - Add isCustomThumbnailSubmission and isCustomThumbnailResult type guards - Use type guards in submitButton, SubmissionComponent, and thumbnailRenderer - These changes resolve TypeScript compilation errors from upstream sync Co-Authored-By: Erkin Alp Güney <erkinalp9035@gmail.com>
- Add licenseKey, paymentStatus, and freeActivation to SBConfig - Remove crossExtension import and DeArrow promotion code (no longer needed after merge) - Fix TitleFormatting import in YourWorkComponent - Add type guards to remaining thumbnail timestamp access sites Co-Authored-By: Erkin Alp Güney <erkinalp9035@gmail.com>
Add freeTrialStart, freeTrialEnded, freeAccessRequestStart, freeTrialDuration, and freeAccessWaitingPeriod to match upstream DeArrow config Co-Authored-By: Erkin Alp Güney <erkinalp9035@gmail.com>
Add activated, alreadyActivated, and showActivatedMessage properties to SBConfig. Fix remaining thumbnail timestamp access in dataFetching.ts using type guard. Co-Authored-By: Erkin Alp Güney <erkinalp9035@gmail.com>
Co-Authored-By: Erkin Alp Güney <erkinalp9035@gmail.com>
Co-Authored-By: Erkin Alp Güney <erkinalp9035@gmail.com>
…ing prop Co-Authored-By: Erkin Alp Güney <erkinalp9035@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test this pull request, follow the instructions in the wiki.
Summary
This PR syncs EditTogether with the latest upstream versions:
All EditTogether branding (pencil icons, naming, server URLs) has been preserved throughout the sync.
Key Changes
Type System Fixes
To resolve TypeScript compilation errors after the merge, several type-related changes were made:
Added missing config properties to match upstream DeArrow:
formatCasualTitles,licenseKey,paymentStatus,activated,alreadyActivated,freeActivation,freeTrialStart,freeTrialEnded,freeAccessRequestStart,freeTrialDuration,freeAccessWaitingPeriod,showActivatedMessageFixed union type handling for thumbnails:
actualValueoptional inShowCustomBrandingInfotypeisCustomThumbnailSubmission,isCustomThumbnailResult) to properly narrow union typesUpdated function signatures:
headersparameter toasyncRequestToServerandsendRequestToServertitleFormattingprop toYourWorkComponentfor upstream compatibilityCross-Extension Code Removal
Since EditTogether merges both SponsorBlock and DeArrow into a single extension, the following cross-extension communication code was removed:
crossExtension.tsmodule and all importsdearrowPromotion.tsmodule and promotion logicbackground.tsUpstream Features
This sync includes all new features and bug fixes from upstream SponsorBlock 6.1.0 and DeArrow 2.1.11. See the upstream changelogs for details.
Testing Checklist
Critical areas to test:
Known limitations:
Link to Devin Session
https://app.devin.ai/sessions/1f8dabc5c6824a5a8717c30bc8d1894c
Requested by: Erkin Alp Güney (erkinalp9035@gmail.com) / @erkinalp