Close and join thread pools between tests#1724
Merged
sijis merged 2 commits intoerrbotio:masterfrom May 21, 2025
Merged
Conversation
nzlosh
approved these changes
Apr 28, 2025
https://bugs.debian.org/1103066 reported test failures on Debian's i386 architecture. After some digging I found that tests were hitting `ENOMEM` depending on which other tests had been run previously, suggesting test isolation problems; i386 has a more limited address space than most other architectures so is more likely to run into this sort of thing. Forcing thread pools to be shut down between tests seems to avoid this problem.
sijis
force-pushed
the
tests-shut-down-thread-pools
branch
from
5c5d4d5 to
ed22a0c
Compare
Contributor
|
@cjwatson thank you! |
kayman-mk
pushed a commit
to Hapag-Lloyd/errbot
that referenced
this pull request
Jul 2, 2025
* Close and join thread pools between tests https://bugs.debian.org/1103066 reported test failures on Debian's i386 architecture. After some digging I found that tests were hitting `ENOMEM` depending on which other tests had been run previously, suggesting test isolation problems; i386 has a more limited address space than most other architectures so is more likely to run into this sort of thing. Forcing thread pools to be shut down between tests seems to avoid this problem. * docs: add info to CHANGES --------- Co-authored-by: Sijis Aviles <sijis.aviles@gmail.com> (cherry picked from commit da7f5e9)
kayman-mk
pushed a commit
to Hapag-Lloyd/errbot
that referenced
this pull request
Jul 2, 2025
* Close and join thread pools between tests https://bugs.debian.org/1103066 reported test failures on Debian's i386 architecture. After some digging I found that tests were hitting `ENOMEM` depending on which other tests had been run previously, suggesting test isolation problems; i386 has a more limited address space than most other architectures so is more likely to run into this sort of thing. Forcing thread pools to be shut down between tests seems to avoid this problem. * docs: add info to CHANGES --------- Co-authored-by: Sijis Aviles <sijis.aviles@gmail.com> (cherry picked from commit da7f5e9)
kayman-mk
pushed a commit
to Hapag-Lloyd/errbot
that referenced
this pull request
Jul 2, 2025
* Close and join thread pools between tests https://bugs.debian.org/1103066 reported test failures on Debian's i386 architecture. After some digging I found that tests were hitting `ENOMEM` depending on which other tests had been run previously, suggesting test isolation problems; i386 has a more limited address space than most other architectures so is more likely to run into this sort of thing. Forcing thread pools to be shut down between tests seems to avoid this problem. * docs: add info to CHANGES --------- Co-authored-by: Sijis Aviles <sijis.aviles@gmail.com> (cherry picked from commit da7f5e9)
kayman-mk
pushed a commit
to Hapag-Lloyd/errbot
that referenced
this pull request
Jul 2, 2025
* Close and join thread pools between tests https://bugs.debian.org/1103066 reported test failures on Debian's i386 architecture. After some digging I found that tests were hitting `ENOMEM` depending on which other tests had been run previously, suggesting test isolation problems; i386 has a more limited address space than most other architectures so is more likely to run into this sort of thing. Forcing thread pools to be shut down between tests seems to avoid this problem. * docs: add info to CHANGES --------- Co-authored-by: Sijis Aviles <sijis.aviles@gmail.com> (cherry picked from commit da7f5e9)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.debian.org/1103066 reported test failures on Debian's i386 architecture. After some digging I found that tests were hitting
ENOMEMdepending on which other tests had been run previously, suggesting test isolation problems; i386 has a more limited address space than most other architectures so is more likely to run into this sort of thing. Forcing thread pools to be shut down between tests seems to avoid this problem.