limit region owners and members by new semi generic perm#416
Open
Galajus wants to merge 2 commits intoespidev:masterfrom
Open
limit region owners and members by new semi generic perm#416Galajus wants to merge 2 commits intoespidev:masterfrom
Galajus wants to merge 2 commits intoespidev:masterfrom
Conversation
protectionstones.members-limit.<integer> default 0 protectionstones.owners-limit.<integer> default 1 perm is necessary to add any member/owner
Owner
|
I apologize for the delay in review. I am not really sure about this feature, it appears you want to add a permission to explicitly cap the number of members or owners that a player can add to any region? To me it's a bit strange of a feature because players with higher limits can add more to the region instead, I haven't really had any requests for this so I think it can be a bit confusing to add to the base plugin. While I would prefer if it was a config option rather than a permission, I do see the usecase of wanting to tailor it to the person... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
protectionstones.members-limit. default 0
protectionstones.owners-limit. default 1
perm is necessary to add any member/owner
