Chores/setup herb formatter #1133
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
CI pété... mais dodo ! |
Member
lol |
Contributor
Author
|
Repassée en draft tant que herb-formatter duplique des noeuds (cf marcoroth/herb#564) |
|
Hey @jbfeldis, sorry for the trouble caused 🙏🏼 I'm working a fix (marcoroth/herb#591) that should fix the duplication bug in the next release! Thanks for reporting! |
jbfeldis
force-pushed
the
chores/setup-herb-formatter
branch
from
40d893b to
a781521
Compare
jbfeldis
force-pushed
the
chores/setup-herb-formatter
branch
from
a781521 to
4a2478c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #404
Format des views avec le formatter (experimental) de Herb (https://herb-tools.dev/projects/formatter).
Le CI devrait fonctionner (il check, il ne format pas), sous docker ça semble ok aussi. En local j'ai l'impression que ça fonctionne bien.
Ajouté dans le makefile sous
make lintetmake fix-lintpour ne pas polluer.