Skip to content

Conversation

@pauldowman
Copy link
Contributor

@pauldowman pauldowman commented Dec 23, 2025

Description

Most of the git submodules use https (the forge libs). But the three newest ones (the explicitly added ones) use SSH. They should be consistent. git submodule update won't work for anyone who doesn't have an SSH public key registered with github, which is less common for most contributors than github auth via https.

NOTE! This means everyone will need to do git submodule sync && git submodule update.

Tests

Additional context

Metadata

@codecov
Copy link

codecov bot commented Dec 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.36%. Comparing base (722b12f) to head (a9ca06b).
⚠️ Report is 19 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #18690       +/-   ##
============================================
+ Coverage    66.89%   77.36%   +10.46%     
============================================
  Files          189      134       -55     
  Lines        11244     7213     -4031     
============================================
- Hits          7522     5580     -1942     
+ Misses        3576     1633     -1943     
+ Partials       146        0      -146     
Flag Coverage Δ
cannon-go-tests-64 ?
contracts-bedrock-tests 77.36% <ø> (+10.74%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 89 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@opgitgovernance opgitgovernance added the S-stale Status: Will be closed unless there is activity label Jan 7, 2026
@opgitgovernance
Copy link
Contributor

This pr has been automatically marked as stale and will be closed in 5 days if no updates

@pauldowman pauldowman marked this pull request as ready for review January 8, 2026 15:08
@pauldowman pauldowman requested a review from a team as a code owner January 8, 2026 15:08
@pauldowman pauldowman requested a review from joshklop January 8, 2026 15:08
@pauldowman pauldowman added this pull request to the merge queue Jan 8, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 8, 2026
@pauldowman pauldowman added this pull request to the merge queue Jan 8, 2026
Merged via the queue into develop with commit 198df93 Jan 8, 2026
94 checks passed
@pauldowman pauldowman deleted the pd/submodules-use-https branch January 8, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-stale Status: Will be closed unless there is activity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants