-
Notifications
You must be signed in to change notification settings - Fork 0
Enable with syntax using the new MetopReader.dataset method.
#17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Solve issue #5 |
pacospace
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for the delay, one comment otherwise LGTM
|
|
||
| # Optional: version info | ||
| __version__ = "0.1.0" | ||
| __version__ = "0.1.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
according to standard https://semver.org/ this should be 0.2.0 if we are introducing new funcionality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have to do it like that since we are still in version 0.y.z
- Major version zero (0.y.z) is for initial development. Anything MAY change at any time. The public API SHOULD NOT be considered stable.
The julia package manager uses a slightly different approach to 0.y.z versions where z is incremented for non-breaking changes and y is incremented for breaking changes.
https://pkgdocs.julialang.org/v1/compatibility/#compat-pre-1.0
So if you think 0.2.0 is more pythonic then I will change it but we don't have to do it according to semver.
| [project] | ||
| name = "metoppy" | ||
| version = "0.1.0" | ||
| version = "0.1.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
according to standard https://semver.org/ this should be 0.2.0 if we are introducing new functionality.
pacospace
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
MetopReader.datasetmethod to enable using thewithsyntax