-
Notifications
You must be signed in to change notification settings - Fork 91
CI: testing python 3.14 and sphinx9 and docutils 0.22 #704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
afc0b8d to
a43342b
Compare
417c88e to
32e4bac
Compare
32e4bac to
b976adb
Compare
49b335d to
428a4ef
Compare
|
OK, so we have some docutils 0.22 incompatibilities for the tests. I've just merged something for sphinx-tabs that may be good enough workaround here, too, and I'm planning to get back to trying it next week. |
|
It looks like this is done except that some of the jobs are picking up newer pillow (12.x) or are not compatible with the one we pin (py3.14 and pillow 11.0) -- So I'm a little bit stuck. @choldgraf - would you help out, should I just: xfail the few tests that are effected if it's not the correct pillow version; or update it to be 12.0.0 everywhere? If the latter; what is the way to update the expected outputs? |
e6509c0 to
91273a6
Compare
| if docutils.__version_info__ < (0, 22): | ||
| data = data.replace('linenos="False"', 'linenos="0"') | ||
| data = data.replace('nowrap="False"', 'nowrap="0"') | ||
| data = data.replace('linenos="True"', 'linenos="1"') | ||
| data = data.replace('internal="True"', 'internal="1"') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not do it the other way around? then you don’t need to change all the XML and you can just remove this block once 0.22 is the lowest supported version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because this way the files are docutils 0.22 compatible and this workaround can be removed when the older versions are dropped.
The problem with this pr has nothing to do with docutils any more, but are stuck with the image tests.
This is to close #680 and other cleanups