[FIX] Support section elements as well as div.section #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Investigating jupyter-book/jupyter-book#1762 (comment) it seems that this module needs to be updated to support the use of
<section>elements (which have superseded<div class="section">elements).This PR updates
sphinx-commentsto support both ways of working. I also noticed that (on Chrome at least)querySelectorAllreturns[]when there are not matches, notnull, so I've modified the script to cope there and exit cleanly rather than throw an error.(Sorry, didn't see https://github.com/executablebooks/.github/blob/d375020a952a579cca1c1e642b248a36da606b8b/CONTRIBUTING.md#commit-messages until opening this PR so the commit message is not properly formatted.)