resistor-color: avoid incorrect analysis for object-literal solutions #171
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Avoids producing misleading analyzer feedback when solutions use
object-literal access patterns that the resistor-color analyzer does
not explicitly recognize.
Details
The analyzer currently attempts to classify object-based solutions even
when they do not match the canonical patterns it understands, which can
result in confusing or incorrect comments.
This change makes the analyzer conservative in those cases and skips
judgement rather than guessing.
Motivation
This aligns with the discussion in #127 and follows Exercism’s principle
of avoiding misleading feedback when analysis is uncertain.