Skip to content

Make instructions consistent with (y, x) and (height, width) ordering #939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mk-mxp merged 1 commit into from
Nov 25, 2025
Merged

Make instructions consistent with (y, x) and (height, width) ordering #939

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions exercises/concept/windowing-system/.docs/instructions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ The following image is representative of the values you will be working with bel
```text
╔════════════════════════════════════════════════════════════╗
║ ║
║ position::$x,_ ║
║ position::$y \ ║
║ position::$y,_ ║
║ position::$x \ ║
║ \<---- size::$width ----> ║
║ ^ *──────────────────────┐ ║
║ | │ title │ ║
Expand All @@ -26,39 +26,39 @@ The following image is representative of the values you will be working with bel

## 1. Define the properties of the Program Window

Using the provided class scaffold, provide the properties for the `x`, `y`, `height`, and `width` values.
Using the provided class scaffold, provide the properties for the `y`, `x`, `height`, and `width` values.

```php
<?php

$window = new ProgramWindow();
$window->x; // => null
$window->y; // => null
$window->width; // => null
$window->x; // => null
$window->height; // => null
$window->width; // => null
```

## 2. Define the initial values for the program window

Define a constructor function for `ProgramWindow`.
It should not take any arguments, but during the constructor execution set the default values for its properties.
It should set the initial `x` and `y` values to `0`.
It should set the initial `width` and `height` to an `800x600` screen size.
It should set the initial `y` and `x` values to `0`.
It should set the initial `height` and `width` to a `600x800` screen size.

```php
<?php

$window = new ProgramWindow();
$window->x; // => 0
$window->y; // => 0
$window->width; // => 800
$window->y; // => 0
$window->x; // => 0
$window->height; // => 600
$window->width; // => 800
```

## 3. Define a function to resize the window

Define a new class in `Size.php` for a Size class.
It should take constructor arguments to set an `height` and `width` property.
It should take constructor arguments to set the `height` and `width` properties.
Additionally `ProgramWindow` requires a resize function, which receives the `Size` object instance and updates its own properties.

```php
Expand All @@ -77,7 +77,7 @@ $window->width;
## 4. Define a function to move the window

Define a new class in `Position.php` for a Position class.
It should take constructor arguments to set a `y` and `x` property.
It should take constructor arguments to set the `y` and `x` properties.
Additionally `ProgramWindow` requires a move function, which receives the `Position` object instance and updates its own properties.

```php
Expand Down
Loading