Skip to content

Conversation

@glaxxie
Copy link
Contributor

@glaxxie glaxxie commented Oct 7, 2025

Sync docs for powershell track

Sync docs for powershell track
@github-actions
Copy link

github-actions bot commented Oct 7, 2025

Hello 👋 Thanks for your PR.

This repo does not currently have dedicated maintainers. Our cross-track maintainers team will attempt to review and merge your PR, but it will likely take longer for your PR to be reviewed.

If you enjoy contributing to Exercism and have a track-record of doing so successfully, you might like to become an Exercism maintainer for this track.

Please feel free to ask any questions, or chat to us about anything to do with this PR or the reviewing process on the Exercism forum.

(cc @exercism/cross-track-maintainers)

@BNAndras
Copy link
Member

BNAndras commented Oct 7, 2025

I see several tests.toml files being updated but not the test suites being updated. Is that a separate PR?

@glaxxie
Copy link
Contributor Author

glaxxie commented Oct 7, 2025

I see several tests.toml files being updated but not the test suites being updated. Is that a separate PR?

Yes, sir. I did the same thing last time, anything that touch test suites or solution that might affect the exercise is for a different PR.
Although in hindsight I should include the toml and the test suite change in the same PR, separate from just the docs

@glaxxie glaxxie requested a review from BNAndras October 8, 2025 05:26
@BNAndras
Copy link
Member

BNAndras commented Oct 8, 2025

I'm still confused. So the updated tests.toml files in this PR are for exercises where you don't need to update the test suite? Or are you syncing all the updated test.toml files now and then adding the changed tests separately?

@glaxxie
Copy link
Contributor Author

glaxxie commented Oct 8, 2025

It's the latter case. Typically I do one update for the docs only (which doesnt affect test suite and doesn't need re-run), and then I do another PR when I make changes for test suites, the toml are suppose to go along with that 2nd PR as well for clarity but I made a mistake to include them in this first one.
If you are ok with it this time then we can just proceed, and then I will queue up that 2nd PR with the test suites updated (already finished), otherwise I can remove the toml files from this one and move it to the 2nd PR.

@IsaacG
Copy link
Member

IsaacG commented Oct 11, 2025

Please keep the tests in sync with the tests.toml files.

@glaxxie glaxxie closed this Oct 11, 2025
This reverts commit c3e21ba.
@glaxxie glaxxie reopened this Oct 11, 2025
@glaxxie glaxxie closed this Oct 11, 2025
@glaxxie glaxxie deleted the sync-docs branch October 11, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants