Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions builtin/builtin_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,21 @@ func TestBuiltin_errors(t *testing.T) {
}
}

// The get() builtin must return an error when called with
// insufficient arguments at runtime, even if compile-time checks
// are bypassed (regression test for OSS-Fuzz #479270603).
func TestBuiltin_get_runtime_args_check(t *testing.T) {
code := `$env(''matches'i'?t:get().UTC())`
env := map[string]any{"t": 1}

program, err := expr.Compile(code, expr.Env(env))
require.NoError(t, err)

_, err = expr.Run(program, env)
require.Error(t, err)
assert.Contains(t, err.Error(), "invalid number of arguments")
}

func TestBuiltin_types(t *testing.T) {
env := map[string]any{
"num": 42,
Expand Down
3 changes: 3 additions & 0 deletions builtin/lib.go
Original file line number Diff line number Diff line change
Expand Up @@ -564,6 +564,9 @@ func flatten(arg reflect.Value, depth int) ([]any, error) {
}

func get(params ...any) (out any, err error) {
if len(params) < 2 {
return nil, fmt.Errorf("invalid number of arguments (expected 2, got %d)", len(params))
}
from := params[0]
i := params[1]
v := reflect.ValueOf(from)
Expand Down
Loading