Fix impossible unsigned integer comparisons in Abs() function #919
+38
−25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The
Abs()function inbuiltin/lib.gocontained unreachable conditional branches for unsigned integer types. Unsigned integers cannot be negative, yet the code checkedif x < 0before returning.This pattern was repeated for
uint,uint8,uint16,uint32, anduint64.Changes
Result
Eliminates 20 lines of dead code, improves clarity, and removes a potential source of confusion for maintainers.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.