Skip to content

ci(deploy): include .well-known folder in GitHub Pages deployment #2166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ShubhamOulkar wants to merge 2 commits into
base: gh-pages
Choose a base branch
from
Open

ci(deploy): include .well-known folder in GitHub Pages deployment #2166

ShubhamOulkar wants to merge 2 commits into from

Conversation

@ShubhamOulkar
Copy link
Contributor

@ShubhamOulkar ShubhamOulkar commented Jan 21, 2026 •
edited
Loading

We can not access file at https://expressjs.com/.well-known/security.txt because .well-known directory is ignored by action upload-pages-artifact@v4.

  • Remove unsupported parameters
  • downgrade to v3 / use deploy from branch from settings.

PR #2162 #1974

@ShubhamOulkar ShubhamOulkar requested a review from a team as a code owner January 21, 2026 10:10
@netlify
Copy link

netlify bot commented Jan 21, 2026 •
edited
Loading

✅ Deploy Preview for expressjscom-preview ready!

Name Link
🔨 Latest commit abed848
🔍 Latest deploy log https://app.netlify.com/projects/expressjscom-preview/deploys/697c1e4202a68f0008dc481a
😎 Deploy Preview https://deploy-preview-2166--expressjscom-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 98 (no change from production)
Accessibility: 87 (no change from production)
Best Practices: 100 (no change from production)
SEO: 94 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

ShubhamOulkar
ShubhamOulkar commented Jan 21, 2026
View reviewed changes
@ShubhamOulkar ShubhamOulkar added the needs tech review A doc edit that requires technical review before merging label Jan 21, 2026
@ShubhamOulkar
Copy link
Contributor Author

ShubhamOulkar commented Jan 30, 2026

@bjohansebas, should we close this PR?

@bjohansebas
Copy link
Member

bjohansebas commented Jan 30, 2026

Let’s try testing by going back to the previous version.

jonchurch
jonchurch requested changes Jan 30, 2026
View reviewed changes
Copy link
Member

@jonchurch jonchurch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened #2173 to address the invalid config and allow uploading .well-known without pinning back any actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjohansebas bjohansebas bjohansebas left review comments

@jonchurch jonchurch jonchurch requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

needs tech review A doc edit that requires technical review before merging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ShubhamOulkar @bjohansebas @jonchurch